Merge pull request #298 from ZD292/Branch-v1.4

Branch v1.4
AY2324S1-CS2103T-T10-3 · Nov 13, 2023 · 3caed11 · 3caed11
2 parents c38db26 + 0af4678
commit 3caed11
Show file tree

Hide file tree

Showing 15 changed files with 50 additions and 11 deletions.
diff --git a/docs/diagrams/AddCommandSequenceDiagram.puml b/docs/diagrams/AddCommandSequenceDiagram.puml
@@ -99,8 +99,13 @@ activate CommandResult
 CommandResult --> AddCommand
 deactivate CommandResult
 
+
 AddCommand --> LogicManager : result
 deactivate AddCommand
+
+AddCommand -[hidden]-> AddressBookParser
+destroy AddCommand
+
 [<--LogicManager
 deactivate LogicManager
 

diff --git a/docs/diagrams/AddGroupMeetingTimeSequenceDiagram.puml b/docs/diagrams/AddGroupMeetingTimeSequenceDiagram.puml
@@ -64,6 +64,10 @@ deactivate CommandResult
 
 AddGroupMeetingTimeCommand --> LogicManager : result
 deactivate AddGroupMeetingTimeCommand
+
+AddGroupMeetingTimeCommand-[hidden]-> AddressBookParser
+destroy AddGroupMeetingTimeCommand
+
 [<--LogicManager
 deactivate LogicManager
 

diff --git a/docs/diagrams/AddTimeSequenceDiagram.puml b/docs/diagrams/AddTimeSequenceDiagram.puml
@@ -64,6 +64,10 @@ deactivate CommandResult
 
 AddTimeCommand --> LogicManager : result
 deactivate AddTimeCommand
+
+AddTimeCommand -[hidden]-> AddressBookParser
+destroy AddTimeCommand
+
 [<--LogicManager
 deactivate LogicManager
 

diff --git a/docs/diagrams/CreateGroupSequenceDiagram.puml b/docs/diagrams/CreateGroupSequenceDiagram.puml
@@ -65,6 +65,9 @@ deactivate CommandResult
 CreateGroupCommand --> LogicManager : result
 deactivate CreateGroupCommand
 
+CreateGroupCommand -[hidden]-> AddressBookParser
+destroy CreateGroupCommand
+
 [<--LogicManager
 deactivate LogicManager
 @enduml
diff --git a/docs/diagrams/DeletePersonSequenceDiagram.puml b/docs/diagrams/DeletePersonSequenceDiagram.puml
@@ -79,6 +79,9 @@ deactivate CommandResult
 DeletePersonCommand --> LogicManager : result
 deactivate DeletePersonCommand
 
+DeletePersonCommand -[hidden]-> AddressBookParser
+destroy DeletePersonCommand
+
 [<--LogicManager
 deactivate LogicManager
 @enduml
diff --git a/docs/diagrams/DeletePersonTimeDiagram.puml → ...rams/DeletePersonTimeSequenceDiagram.puml b/docs/diagrams/DeletePersonTimeDiagram.puml → ...rams/DeletePersonTimeSequenceDiagram.puml
@@ -65,6 +65,9 @@ deactivate CommandResult
 DeleteTimeCommand --> LogicManager : result
 deactivate DeleteTimeCommand
 
+DeleteTimeCommand -[hidden]-> AddressBookParser
+destroy DeleteTimeCommand
+
 [<--LogicManager
 deactivate LogicManager
 @enduml
diff --git a/docs/diagrams/FindFreeTimeSequenceDiagram.puml b/docs/diagrams/FindFreeTimeSequenceDiagram.puml
@@ -81,8 +81,6 @@ activate CommandResult
 
 CommandResult --> FindFreeTimeCommand
 deactivate CommandResult
-CommandResult-[hidden]-> AddressBookParser
-destroy CommandResult
 
 FindFreeTimeCommand --> LogicManager
 deactivate FindFreeTimeCommand

diff --git a/docs/diagrams/FindPersonSequenceDiagram.puml b/docs/diagrams/FindPersonSequenceDiagram.puml
@@ -65,6 +65,9 @@ deactivate CommandResult
 FindPersonCommand --> LogicManager : result
 deactivate FindPersonCommand
 
+FindPersonCommand -[hidden]-> AddressBookParser
+destroy FindPersonCommand
+
 [<--LogicManager
 deactivate LogicManager
 @enduml
diff --git a/docs/diagrams/GroupPersonSequenceDiagram.puml b/docs/diagrams/GroupPersonSequenceDiagram.puml
@@ -72,9 +72,6 @@ activate CommandResult
 CommandResult --> GroupPersonCommand
 deactivate CommandResult
 
-CommandResult -[hidden]-> AddressBookParser
-destroy CommandResult
-
 GroupPersonCommand --> LogicManager
 
 deactivate GroupPersonCommand

diff --git a/docs/diagrams/GroupRemarkSequenceDiagram.puml b/docs/diagrams/GroupRemarkSequenceDiagram.puml
@@ -73,7 +73,15 @@ activate CommandResult
 CommandResult --> GroupRemarkCommand
 deactivate CommandResult
 
+
+
 GroupRemarkCommand --> LogicManager: result
+deactivate GroupRemarkCommand
+
+GroupRemarkCommand -[hidden]-> AddressBookParser
+destroy GroupRemarkCommand
+
 [<-- LogicManager
+deactivate LogicManager
 
 @enduml
diff --git a/docs/diagrams/ListCommandSequenceDiagram.puml b/docs/diagrams/ListCommandSequenceDiagram.puml
@@ -15,6 +15,7 @@ participant ":Model" as Model MODEL_COLOR
 end box
 
 
+
 [-> LogicManager : execute("list")
 activate LogicManager
 
@@ -50,9 +51,11 @@ deactivate AddressBookParser
 LogicManager -> ListCommand : execute()
 activate ListCommand
 
-ListCommand -> Model : updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS)
+
+ListCommand -> Model : updateFilteredPersonList(PREDICATE ...)
 activate Model
 
+
 Model --> ListCommand
 deactivate Model
 
@@ -66,6 +69,10 @@ deactivate CommandResult
 ListCommand --> LogicManager : result
 deactivate ListCommand
 
+ListCommand -[hidden]-> AddressBookParser
+destroy ListCommand
+
+
 [<--LogicManager
 deactivate LogicManager
 

diff --git a/docs/diagrams/ListGroupSequenceDiagram.puml b/docs/diagrams/ListGroupSequenceDiagram.puml
@@ -66,6 +66,9 @@ deactivate CommandResult
 ListGroupCommand --> LogicManager : result
 deactivate ListGroupCommand
 
+ListGroupCommand -[hidden]->AddressBookParser
+destroy ListGroupCommand
+
 [<--LogicManager
 deactivate LogicManager
 

diff --git a/docs/diagrams/ListTimePersonSequenceDiagram.puml b/docs/diagrams/ListTimePersonSequenceDiagram.puml
@@ -66,6 +66,9 @@ deactivate CommandResult
 ListTimePersonCommand --> LogicManager: result
 deactivate ListTimePersonCommand
 
+ListTimePersonCommand -[hidden]->AddressBookParser
+destroy ListTimePersonCommand
+
 [<-- LogicManager
 deactivate LogicManager
 

diff --git a/docs/diagrams/UngroupPersonSequenceDiagram.puml b/docs/diagrams/UngroupPersonSequenceDiagram.puml
@@ -66,8 +66,6 @@ activate CommandResult
 CommandResult --> UngroupPersonCommand
 deactivate CommandResult
 UngroupPersonCommand --> LogicManager
-CommandResult -[Hidden]-> UngroupPersonCommand
-destroy CommandResult
 
 deactivate UngroupPersonCommand
 

diff --git a/docs/team/zd292.md b/docs/team/zd292.md
@@ -9,7 +9,7 @@ AddressBook - Level 3 is a desktop address book application used for teaching So
 
 Given below are my contributions to the project.
 
-* **New Feature**: Added the ability to group a contact.
+* **New Feature**: Added the ability to group a contact. 
   * What it does: Allows the user to group a contact.
   * Justification: This is a core features which improves the product significantly because it will help our target audience, university students, organise their contacts into their various project groups so that they do not mix up contacts with similar names. This allows university students to neatly organise their contacts.
   * Highlights: This enhancement affects existing commands and commands to be added in the future. For example, the relationship between group and person is that a group has a list of group members and a person has a list of groups that they are in.
@@ -28,14 +28,14 @@ Given below are my contributions to the project.
 
 * **Documentation**:
   * User Guide:
-    * Added documentation for the features
+    * Added documentation for the features [\#142](https://github.com/AY2324S1-CS2103T-T10-3/tp/pull/142)
     * Listing Meeting Time From a Group `listtime`
     * Finding Free Time of a Group `findfreetime`
     * Viewing Help: `help`
     * Clearing all Data: `clear`
 
   * Developer Guide:
-    * Add sequence diagram for grouping a contact
+    * Add sequence diagram for grouping a contact [\#296](https://github.com/AY2324S1-CS2103T-T10-3/tp/pull/296)
     * Add sequence diagram for FindFreeTime command
     * Add activity diagram for FindFreeTime command