Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add test cases" #254

Merged
merged 1 commit into from
Nov 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@ public boolean equals(Object other) {
// state check
GroupRemarkCommand e = (GroupRemarkCommand) other;
return groupRemark.equals(e.groupRemark)
&& groupName.equals(e.groupName);
&& groupRemark.equals(e.groupName);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,7 @@ public class ListTimeGroupCommand extends ListTimeCommand {
+ "Please provide the group's full name as in the existing contactlist.";
private final Group group;

/**
* Constructor of ListTimeGroupCommand
*
* @param group Group to list time for.
*/
public ListTimeGroupCommand(Group group) {
requireNonNull(group);
this.group = group;
}
@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,7 @@ public class ListTimePersonCommand extends ListTimeCommand {
+ "Please provide the person's full name as in the existing contactlist.";
private final Name personName;

/**
* Constructor of ListTimePersonCommand
*
* @param personName Name of person to list time for.
*/
public ListTimePersonCommand(Name personName) {
requireNonNull(personName);
this.personName = personName;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,12 @@ public boolean equals(Object other) {
return true;
}

if (!(other instanceof UngroupPersonCommand)) {
if (!(other instanceof GroupPersonCommand)) {
return false;
}

UngroupPersonCommand otherUngroupPersonCommand = (UngroupPersonCommand) other;
return this.personName.equals(otherUngroupPersonCommand.personName)
&& this.groupName.equals(otherUngroupPersonCommand.groupName);
return this.equals(otherUngroupPersonCommand);

}

Expand Down

This file was deleted.

Loading