Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch v1.4 #298

Merged
merged 3 commits into from
Nov 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/diagrams/AddCommandSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,13 @@ activate CommandResult
CommandResult --> AddCommand
deactivate CommandResult


AddCommand --> LogicManager : result
deactivate AddCommand

AddCommand -[hidden]-> AddressBookParser
destroy AddCommand

[<--LogicManager
deactivate LogicManager

Expand Down
4 changes: 4 additions & 0 deletions docs/diagrams/AddGroupMeetingTimeSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ deactivate CommandResult

AddGroupMeetingTimeCommand --> LogicManager : result
deactivate AddGroupMeetingTimeCommand

AddGroupMeetingTimeCommand-[hidden]-> AddressBookParser
destroy AddGroupMeetingTimeCommand

[<--LogicManager
deactivate LogicManager

Expand Down
4 changes: 4 additions & 0 deletions docs/diagrams/AddTimeSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ deactivate CommandResult

AddTimeCommand --> LogicManager : result
deactivate AddTimeCommand

AddTimeCommand -[hidden]-> AddressBookParser
destroy AddTimeCommand

[<--LogicManager
deactivate LogicManager

Expand Down
3 changes: 3 additions & 0 deletions docs/diagrams/CreateGroupSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ deactivate CommandResult
CreateGroupCommand --> LogicManager : result
deactivate CreateGroupCommand

CreateGroupCommand -[hidden]-> AddressBookParser
destroy CreateGroupCommand

[<--LogicManager
deactivate LogicManager
@enduml
3 changes: 3 additions & 0 deletions docs/diagrams/DeletePersonSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ deactivate CommandResult
DeletePersonCommand --> LogicManager : result
deactivate DeletePersonCommand

DeletePersonCommand -[hidden]-> AddressBookParser
destroy DeletePersonCommand

[<--LogicManager
deactivate LogicManager
@enduml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ deactivate CommandResult
DeleteTimeCommand --> LogicManager : result
deactivate DeleteTimeCommand

DeleteTimeCommand -[hidden]-> AddressBookParser
destroy DeleteTimeCommand

[<--LogicManager
deactivate LogicManager
@enduml
2 changes: 0 additions & 2 deletions docs/diagrams/FindFreeTimeSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ activate CommandResult

CommandResult --> FindFreeTimeCommand
deactivate CommandResult
CommandResult-[hidden]-> AddressBookParser
destroy CommandResult

FindFreeTimeCommand --> LogicManager
deactivate FindFreeTimeCommand
Expand Down
3 changes: 3 additions & 0 deletions docs/diagrams/FindPersonSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ deactivate CommandResult
FindPersonCommand --> LogicManager : result
deactivate FindPersonCommand

FindPersonCommand -[hidden]-> AddressBookParser
destroy FindPersonCommand

[<--LogicManager
deactivate LogicManager
@enduml
3 changes: 0 additions & 3 deletions docs/diagrams/GroupPersonSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ activate CommandResult
CommandResult --> GroupPersonCommand
deactivate CommandResult

CommandResult -[hidden]-> AddressBookParser
destroy CommandResult

GroupPersonCommand --> LogicManager

deactivate GroupPersonCommand
Expand Down
8 changes: 8 additions & 0 deletions docs/diagrams/GroupRemarkSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,15 @@ activate CommandResult
CommandResult --> GroupRemarkCommand
deactivate CommandResult



GroupRemarkCommand --> LogicManager: result
deactivate GroupRemarkCommand

GroupRemarkCommand -[hidden]-> AddressBookParser
destroy GroupRemarkCommand

[<-- LogicManager
deactivate LogicManager

@enduml
9 changes: 8 additions & 1 deletion docs/diagrams/ListCommandSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ participant ":Model" as Model MODEL_COLOR
end box



[-> LogicManager : execute("list")
activate LogicManager

Expand Down Expand Up @@ -50,9 +51,11 @@ deactivate AddressBookParser
LogicManager -> ListCommand : execute()
activate ListCommand

ListCommand -> Model : updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS)

ListCommand -> Model : updateFilteredPersonList(PREDICATE ...)
activate Model


Model --> ListCommand
deactivate Model

Expand All @@ -66,6 +69,10 @@ deactivate CommandResult
ListCommand --> LogicManager : result
deactivate ListCommand

ListCommand -[hidden]-> AddressBookParser
destroy ListCommand


[<--LogicManager
deactivate LogicManager

Expand Down
3 changes: 3 additions & 0 deletions docs/diagrams/ListGroupSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ deactivate CommandResult
ListGroupCommand --> LogicManager : result
deactivate ListGroupCommand

ListGroupCommand -[hidden]->AddressBookParser
destroy ListGroupCommand

[<--LogicManager
deactivate LogicManager

Expand Down
3 changes: 3 additions & 0 deletions docs/diagrams/ListTimePersonSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ deactivate CommandResult
ListTimePersonCommand --> LogicManager: result
deactivate ListTimePersonCommand

ListTimePersonCommand -[hidden]->AddressBookParser
destroy ListTimePersonCommand

[<-- LogicManager
deactivate LogicManager

Expand Down
2 changes: 0 additions & 2 deletions docs/diagrams/UngroupPersonSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ activate CommandResult
CommandResult --> UngroupPersonCommand
deactivate CommandResult
UngroupPersonCommand --> LogicManager
CommandResult -[Hidden]-> UngroupPersonCommand
destroy CommandResult

deactivate UngroupPersonCommand

Expand Down
6 changes: 3 additions & 3 deletions docs/team/zd292.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ AddressBook - Level 3 is a desktop address book application used for teaching So

Given below are my contributions to the project.

* **New Feature**: Added the ability to group a contact.
* **New Feature**: Added the ability to group a contact.
* What it does: Allows the user to group a contact.
* Justification: This is a core features which improves the product significantly because it will help our target audience, university students, organise their contacts into their various project groups so that they do not mix up contacts with similar names. This allows university students to neatly organise their contacts.
* Highlights: This enhancement affects existing commands and commands to be added in the future. For example, the relationship between group and person is that a group has a list of group members and a person has a list of groups that they are in.
Expand All @@ -28,14 +28,14 @@ Given below are my contributions to the project.

* **Documentation**:
* User Guide:
* Added documentation for the features
* Added documentation for the features [\#142](https://github.com/AY2324S1-CS2103T-T10-3/tp/pull/142)
* Listing Meeting Time From a Group `listtime`
* Finding Free Time of a Group `findfreetime`
* Viewing Help: `help`
* Clearing all Data: `clear`

* Developer Guide:
* Add sequence diagram for grouping a contact
* Add sequence diagram for grouping a contact [\#296](https://github.com/AY2324S1-CS2103T-T10-3/tp/pull/296)
* Add sequence diagram for FindFreeTime command
* Add activity diagram for FindFreeTime command

Loading