Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch v1.4 #311

Merged
merged 6 commits into from
Nov 13, 2023
Merged

Branch v1.4 #311

merged 6 commits into from
Nov 13, 2023

Conversation

ZD292
Copy link
Collaborator

@ZD292 ZD292 commented Nov 13, 2023

No description provided.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6da15f) 68.84% compared to head (5e5774a) 68.84%.

❗ Current head 5e5774a differs from pull request most recent head 98bd094. Consider uploading reports for the commit 98bd094 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #311   +/-   ##
=========================================
  Coverage     68.84%   68.84%           
  Complexity      705      705           
=========================================
  Files           113      113           
  Lines          2375     2375           
  Branches        269      269           
=========================================
  Hits           1635     1635           
  Misses          624      624           
  Partials        116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lerxuann lerxuann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderhuang559 coderhuang559 merged commit dacad65 into AY2324S1-CS2103T-T10-3:master Nov 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants