Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #31 #44

Merged

Conversation

B-enguin
Copy link

Update AboutUs.md to include Benjamin's photo and details

Add personal image and details to AboutUs.md
Fix 404 error for AboutUs.md.
Fix CI failing for AboutUs.md for newline at EOF.
Changed Benjamin's role to member
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d16b09b) 75.26% compared to head (df39536) 75.26%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #44   +/-   ##
=========================================
  Coverage     75.26%   75.26%           
  Complexity      419      419           
=========================================
  Files            71       71           
  Lines          1338     1338           
  Branches        126      126           
=========================================
  Hits           1007     1007           
  Misses          301      301           
  Partials         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@B-enguin B-enguin added this to the V1.1 milestone Sep 28, 2023
@B-enguin B-enguin self-assigned this Sep 28, 2023
@B-enguin B-enguin linked an issue Sep 28, 2023 that may be closed by this pull request
Copy link

@jianyangg jianyangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jianyangg jianyangg merged commit 4050904 into AY2324S1-CS2103T-T13-3:master Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update AboutUs Benjamin
2 participants