forked from nus-cs2103-AY2324S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UG #225
Merged
MadLamprey
merged 6 commits into
AY2324S1-CS2103T-W09-4:master
from
MadLamprey:branch-UG
Nov 14, 2023
Merged
Update UG #225
MadLamprey
merged 6 commits into
AY2324S1-CS2103T-W09-4:master
from
MadLamprey:branch-UG
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/AY2324S1-CS2103T-W09-4/tp: Enlarge diagrams Fix nits Fix minor formatting issue Remove JsonAdaptedTag UG for filter DG: update search sequence diagram Checkstyle Updated UG Remove tests Bug Fix for assessment tags and UG update Bugfix: add and edit using tags that haven't been created UG and DG updates Update UG Update UG and DG Bugfix: editing scores
* master: (53 commits) Enlarge diagrams Fix nits Fix minor formatting issue Remove JsonAdaptedTag UG for filter DG: update search sequence diagram Checkstyle Updated UG Remove tests Bug Fix for assessment tags and UG update Bugfix: add and edit using tags that haven't been created UG and DG updates Update UG Update UG and DG ParseTag: change tagName to trimmedTag Bugfix: fix bug in editing scores Bugfix: editing scores Pull from upstream Update developer guide Update developer guide ...
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
============================================
+ Coverage 72.97% 73.12% +0.15%
+ Complexity 917 916 -1
============================================
Files 127 126 -1
Lines 3060 3059 -1
Branches 368 370 +2
============================================
+ Hits 2233 2237 +4
+ Misses 728 721 -7
- Partials 99 101 +2 ☔ View full report in Codecov by Sentry. |
ketweeen
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MadLamprey
merged commit Nov 14, 2023
2f218ac
into
AY2324S1-CS2103T-W09-4:master
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.