Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG #225

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Update UG #225

merged 6 commits into from
Nov 14, 2023

Conversation

MadLamprey
Copy link
Collaborator

No description provided.

Misra Aditya added 4 commits November 14, 2023 08:51
* 'master' of https://github.com/AY2324S1-CS2103T-W09-4/tp:
  Enlarge diagrams
  Fix nits
  Fix minor formatting issue
  Remove JsonAdaptedTag
  UG for filter
  DG: update search sequence diagram
  Checkstyle
  Updated UG
  Remove tests
  Bug Fix for assessment tags and UG update
  Bugfix: add and edit using tags that haven't been created
  UG and DG updates
  Update UG
  Update UG and DG
  Bugfix: editing scores
* master: (53 commits)
  Enlarge diagrams
  Fix nits
  Fix minor formatting issue
  Remove JsonAdaptedTag
  UG for filter
  DG: update search sequence diagram
  Checkstyle
  Updated UG
  Remove tests
  Bug Fix for assessment tags and UG update
  Bugfix: add and edit using tags that haven't been created
  UG and DG updates
  Update UG
  Update UG and DG
  ParseTag: change tagName to trimmedTag
  Bugfix: fix bug in editing scores
  Bugfix: editing scores
  Pull from upstream
  Update developer guide
  Update developer guide
  ...
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (ecde317) 72.97% compared to head (393e47f) 73.12%.
Report is 96 commits behind head on master.

Files Patch % Lines
...java/seedu/address/logic/commands/EditCommand.java 78.57% 3 Missing ⚠️
...in/java/seedu/address/model/tag/UniqueTagList.java 0.00% 3 Missing ⚠️
...in/java/seedu/address/logic/parser/ParserUtil.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #225      +/-   ##
============================================
+ Coverage     72.97%   73.12%   +0.15%     
+ Complexity      917      916       -1     
============================================
  Files           127      126       -1     
  Lines          3060     3059       -1     
  Branches        368      370       +2     
============================================
+ Hits           2233     2237       +4     
+ Misses          728      721       -7     
- Partials         99      101       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ketweeen ketweeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MadLamprey MadLamprey merged commit 2f218ac into AY2324S1-CS2103T-W09-4:master Nov 14, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants