Bugfix: number of tag catgories defined #228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended functionality: users should be able to define up to 3 more categories on top of the 3 predefined categories that come with JABPro. Note that the 3 predefined categories were not documented in v1.3 UG BUT this has been the behaviour since v1.3 due to the use of sample data/tags in JABPro and hence this was NOT a behaviour change.
Bug: users can only define up to 2 more categories if they have uncategorised tags (created from doing
edit
oradd
with a tag that hasn't been created)Fix: ignore
uncategorised
tags when counting the number of tag categories that the user has made so far since they technically never intended to create theuncategorised
"category".