Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: number of tag catgories defined #228

Conversation

AriellaCallista
Copy link
Collaborator

@AriellaCallista AriellaCallista commented Nov 14, 2023

Intended functionality: users should be able to define up to 3 more categories on top of the 3 predefined categories that come with JABPro. Note that the 3 predefined categories were not documented in v1.3 UG BUT this has been the behaviour since v1.3 due to the use of sample data/tags in JABPro and hence this was NOT a behaviour change.

Bug: users can only define up to 2 more categories if they have uncategorised tags (created from doing edit or add with a tag that hasn't been created)

Fix: ignore uncategorised tags when counting the number of tag categories that the user has made so far since they technically never intended to create the uncategorised "category".

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bfb6901) 73.12% compared to head (3deaffa) 73.10%.

Files Patch % Lines
...seedu/address/logic/commands/CreateTagCommand.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #228      +/-   ##
============================================
- Coverage     73.12%   73.10%   -0.03%     
  Complexity      916      916              
============================================
  Files           126      126              
  Lines          3059     3060       +1     
  Branches        370      371       +1     
============================================
  Hits           2237     2237              
  Misses          721      721              
- Partials        101      102       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MadLamprey MadLamprey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MadLamprey MadLamprey merged commit 08e780c into AY2324S1-CS2103T-W09-4:master Nov 14, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants