Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug found in list_sales command. #350

Conversation

NaychiMin
Copy link

No description provided.

Copy link

@DextheChik3n DextheChik3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some review comments for coding standards

src/main/java/seedu/cafectrl/data/Menu.java Outdated Show resolved Hide resolved
src/main/java/seedu/cafectrl/data/OrderList.java Outdated Show resolved Hide resolved
Copy link

@DextheChik3n DextheChik3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments and suggestion on introducing variables

src/main/java/seedu/cafectrl/data/OrderList.java Outdated Show resolved Hide resolved
src/main/java/seedu/cafectrl/data/OrderList.java Outdated Show resolved Hide resolved
src/main/java/seedu/cafectrl/data/OrderList.java Outdated Show resolved Hide resolved
Copy link

@DextheChik3n DextheChik3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! great job in squishing the bug 👍 ^ - ^ 👍

@DextheChik3n DextheChik3n merged commit 9b94d06 into AY2324S1-CS2113-T17-2:master Nov 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants