Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 9, Create Ui class and UserOutput enum. #36

Merged

Conversation

NaychiMin
Copy link

Fixes #9

Create Ui class for user input handling and UserOutput enum for user messages.

Copy link

@DextheChik3n DextheChik3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed a small coding standard change and a comment about the showError method

*/
public enum UserOutput {
WELCOME_MESSAGE("Hello! Welcome to CafeCTRL!"),
GOODBYE_MESSAGE("Goodbye <3 Have a great day ahead!")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put the semicolon in line 8 instead of putting it in the next line?

System.out.println(UserOutput.GOODBYE_MESSAGE.message);
}

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that this is not necessary for now.... in my opinion when we start implementing error handling we then include the necessary code if not we might forget about this method in the future so I feel that you can remove this for now :/

Copy link

@DextheChik3n DextheChik3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's good now!

@DextheChik3n DextheChik3n merged commit 3ca6303 into AY2324S1-CS2113-T17-2:master Oct 15, 2023
@ziyi105 ziyi105 added this to the v0.1 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create UI class
3 participants