Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scene domain and associated tap-action #164

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

w531t4
Copy link
Contributor

@w531t4 w531t4 commented Nov 29, 2024

Resolves #135 Request 1.

  • Add scene view
  • Add tap action to activate scene

@w531t4 w531t4 marked this pull request as draft November 30, 2024 00:31
@DigiLive
Copy link
Collaborator

DigiLive commented Nov 30, 2024

Please hold.

Depending on the response of @AalianKhan at #160 (comment), we might introduce the chipscard.

If so, we can apply the chipscard for activating scenes as suggested at #135 (comment).

Also, I'd like to finish #157 with you first.

@w531t4
Copy link
Contributor Author

w531t4 commented Nov 30, 2024

Please hold.

Depending on the response of @AalianKhan at #160 (comment), we might introduce the chipscard.

If so, we can apply the chipscard for activating scenes as suggested at #135 (comment).

Also, I'd like to finish #157 with you first.

@DigiLive absolutely.

@DigiLive DigiLive self-assigned this Dec 13, 2024
@DigiLive DigiLive added the enhancement New feature or request label Dec 13, 2024
Scene entities don't require templating, so the entity-card type is a
better match.
Also, the entity card doesn't require a title or icon to be defined.
It gets this information from hass.
* Not all scenes should be activated at once.
  The controller-card for this domain is now disabled by default, which
  makes properties `iconOn` and `iconOff` obsolete.
* property `offService` is obsolete because scenes can't be turned off.
If a controller-card doesn't have cards to control entities, it has no
use to add one to the view. This fix adds a check and only adds the card
to the view when there are entities to control.
Since the controller card doesn't control anything, it has no use to
add it to the view.
@DigiLive
Copy link
Collaborator

DigiLive commented Dec 14, 2024

@w531t4 Please validate the current state of the branch.

(Don't merge the current main branch into this one)

@DigiLive DigiLive added this to the Release v2.2.0 milestone Dec 14, 2024
@DigiLive DigiLive added Needs Feedback Something needs clarification or a response is expected In Progress Someone is already working on it. labels Dec 20, 2024
@w531t4
Copy link
Contributor Author

w531t4 commented Dec 27, 2024

@DigiLive Bought a dog at the beginning of December, my attention has been rather occupied as of late. I apologize for leaving you hanging here. I should have some time in the next few days to close these things out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request In Progress Someone is already working on it. Needs Feedback Something needs clarification or a response is expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: one-tap to activate Scenes, show in Lighting
2 participants