Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix error syncing while uploading a file #2832

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix: fix error syncing while uploading a file #2832

merged 1 commit into from
Feb 5, 2025

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Jan 31, 2025

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Deployed to https://pr-2832.aam-digital.net/

Abhinegi2
Abhinegi2 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@Abhinegi2 Abhinegi2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this, and it is working as expected.

@sleidig sleidig linked an issue Jan 31, 2025 that may be closed by this pull request
Image/Files are not getting saved in db #2831
Closed
@Abhinegi2
Copy link
Contributor

@sleidig Can you also deploy this on the dev site? I want to test a few things, as the issue #2791 is no longer occurring in my local environment after these and allows multiple database pr changes.
I just wanted to check if #2791 still happens on the dev site or not.

@sleidig
Copy link
Member Author

sleidig commented Feb 5, 2025

Can you also deploy this on the dev site? I want to test a few things, as the issue #2791 is no longer occurring in my local environment after these and allows multiple database pr changes. I just wanted to check if #2791 still happens on the dev site or not.

@Abhinegi2 , dev system has #2757 deployed which also contains this PR here already, so we can probably consider your other issue fixed by this?

@sleidig sleidig merged commit 5b90744 into master Feb 5, 2025
14 checks passed
@sleidig sleidig deleted the fix/file-sync branch February 5, 2025 07:38
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.46.2-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Feb 5, 2025
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.46.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhinegi2 Abhinegi2 Abhinegi2 approved these changes

@tomwwinter tomwwinter Awaiting requested review from tomwwinter

Assignees
No one assigned
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image/Files are not getting saved in db
3 participants
@sleidig @Abhinegi2 @aam-digital-ci