Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unexpected behavior around filters with validators #582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mogman1
Copy link

@mogman1 mogman1 commented Dec 1, 2024

Resolves #574

This calls errors.empty? like the original Validations module in Rails does. This, along with the change in ActiveInteraction's Validation module, restores the expected behavior of being able to cure validation errors while also having the nice side effect of always returning a boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected validation behavior on filters with validators
1 participant