Using namespace dev (#2505)

* [C++] adding missing namespace pgrouting
* [doc] included strings to files & space adjustment on version result
* [allpairs] Adding: use namespace directive
* [alpha_shape] Adding: use namespace directive
* [astar] Adding: use namespace directive
* [bdAstar] Adding: use namespace directive
* [bdDijkstra] Adding: use namespace directive
* [bellman_ford] Adding: use namespace directive
* [breadthFirstSearch] Adding: use namespace directive
* [chinese] Adding: use namespace directive
* [circuits] Adding: use namespace directive
* [coloring] Adding: use namespace directive
* [components] Adding: use namespace directive
* [contraction] Adding: use namespace directive
* [cpp_common] Adding: use namespace directive
* [dagShortestPath] Adding: use namespace directive
* [dijkstra] Adding: use namespace directive
* [dominator] Adding: use namespace directive
* [driving_distance] Adding: use namespace directive
* [ksp] Adding: use namespace directive
* [lineGraph] Adding: use namespace directive
* [max_flow] Adding: use namespace directive
* [mincut] Adding: use namespace directive
* [ordering] Adding: use namespace directive
* [pickDeliver] Adding: use namespace directive
* [planar] Adding: use namespace directive
* [spanningTree] Adding: use namespace directive
* [topologicalSort] Adding: use namespace directive
* [transitiveClosure] Adding: use namespace directive
* [traversal] Adding: use namespace directive
* [trsp] Adding: use namespace directive
* [tsp] Adding: use namespace directive
* [withPoints] Adding: use namespace directive
* [clang] fix clang warnings
* Update locale: commit 370afe5df
* [locale] cleaning comments

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

doc/tsp/pgr_TSP.rst

@@ -153,9 +153,17 @@ Inner Queries
 Matrix SQL
 ...............................................................................
 
-.. include:: ../../src/common/matrixRows_input.c
-   :start-after: Matrix SQL definition start
-   :end-before: Matrix SQL definition end
+.. Matrix SQL definition start
+
+============= ================= =================================================
+Column        Type              Description
+============= ================= =================================================
+``start_vid`` ``ANY-INTEGER``   Identifier of the starting vertex.
+``end_vid``   ``ANY-INTEGER``   Identifier of the ending vertex.
+``agg_cost``  ``ANY-NUMERICAL`` Cost for going from start_vid to end_vid
+============= ================= =================================================
+
+.. Matrix SQL definition end
 
 Result Columns
 -------------------------------------------------------------------------------

doc/tsp/pgr_TSPeuclidean.rst

@@ -115,9 +115,18 @@ Inner Queries
 Coordinates SQL
 ...............................................................................
 
-.. include:: ../../src/common/coordinates_input.c
-   :start-after: Coordinates SQL definition start
-   :end-before: Coordinates SQL definition end
+.. Coordinates SQL definition start
+
+========= ================= =================================================
+Column        Type               Description
+========= ================= =================================================
+``id``    ``ANY-INTEGER``    Identifier of the starting vertex.
+``x``     ``ANY-NUMERICAL``  X value of the coordinate.
+``y``     ``ANY-NUMERICAL``  Y value of the coordinate.
+========= ================= =================================================
+
+.. Coordinates SQL definition end
+
 
 Result Columns
 -------------------------------------------------------------------------------

docqueries/version/doc-full_version.result

@@ -4,9 +4,9 @@ SET client_min_messages TO NOTICE;
 SET
 /* -- q1 */
 SELECT version, library FROM pgr_full_version();
- version |     library
+  version  |     library
 -----------+-----------------
- 3.6.0-dev   | pgrouting-3.6.0
+ 3.6.0-dev | pgrouting-3.6.0
 (1 row)
 
 /* -- q2 */

include/allpairs/pgr_allpairs.hpp

@@ -47,6 +47,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 // TODO(vicky) don't keep it here
 #include "cpp_common/pgr_alloc.hpp"
 
+namespace pgrouting  {
 template < class G > class Pgr_allpairs;
 
 // user's functions
@@ -257,5 +258,6 @@ class Pgr_allpairs {
      };
 };
 
+}  // namespace pgrouting
 
 #endif  // INCLUDE_ALLPAIRS_PGR_ALLPAIRS_HPP_

include/bellman_ford/pgr_bellman_ford.hpp

@@ -50,6 +50,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 
 //******************************************
+namespace pgrouting {
 
 template < class G >
 class Pgr_bellman_ford : public pgrouting::Pgr_messages {
@@ -312,4 +313,6 @@ class Pgr_bellman_ford : public pgrouting::Pgr_messages {
      //@}
 };
 
+}  // namespace pgrouting
+
 #endif  // INCLUDE_BELLMAN_FORD_PGR_BELLMAN_FORD_HPP_

include/cpp_common/basePath_SSEC.hpp

@@ -42,6 +42,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #include "cpp_common/pgr_base_graph.hpp"
 #include "cpp_common/rule.h"
 
+namespace pgrouting {
 
 class Path {
     typedef std::deque< Path_t >::iterator pthIt;
@@ -59,7 +60,6 @@ class Path {
     Path(int64_t s_id, int64_t e_id)
         : m_start_id(s_id), m_end_id(e_id), m_tot_cost(0)
     {}
-    Path(const Path&) = default;
 
     int64_t start_id() const {return m_start_id;}
     void start_id(int64_t value) {m_start_id = value;}
@@ -333,5 +333,6 @@ class Path {
     }
 };
 
+}  // namespace pgrouting
 
 #endif  // INCLUDE_CPP_COMMON_BASEPATH_SSEC_HPP_

include/cpp_common/identifier.h

@@ -39,7 +39,6 @@ namespace pgrouting {
 class Identifier {
  public:
      Identifier() = default;
-     Identifier(const Identifier &v) = default;
      Identifier(const size_t _idx, const int64_t _id);
 
      int64_t id() const;

include/cpp_common/identifiers.hpp

@@ -44,6 +44,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 /* TODO(vicky)
  * compiler check that type T is a integral type
  */
+namespace pgrouting {
 
 template <typename T>
 class Identifiers {
@@ -55,7 +56,6 @@ class Identifiers {
     //! @name constructors
     //@{
     Identifiers<T>() = default;
-    Identifiers<T>(const Identifiers<T>&) = default;
     Identifiers<T>(const std::set<T>& data) {
         m_ids = data;
     }
@@ -250,4 +250,6 @@ class Identifiers {
         }
 };
 
+}  // namespace pgrouting
+
 #endif  // INCLUDE_CPP_COMMON_IDENTIFIERS_HPP_

include/cpp_common/pgr_alloc.hpp

@@ -45,6 +45,8 @@ SPI_pfree(void *pointer);
 }
 
 
+namespace pgrouting {
+
 /*! \fn pgr_alloc(std::size_t size, T *ptr)
 
 \brief allocates memory
@@ -84,4 +86,6 @@ pgr_free(T* ptr) {
 char *
 pgr_msg(const std::string &msg);
 
+}  // namespace pgrouting
+
 #endif  // INCLUDE_CPP_COMMON_PGR_ALLOC_HPP_

include/cpp_common/xy_vertex.h

@@ -40,7 +40,6 @@ namespace pgrouting {
 class XY_vertex {
  public:
   XY_vertex() = default;
-  XY_vertex(const XY_vertex &) = default;
   XY_vertex(const int64_t _id, double _x, double _y) :
       id(_id), point(_x, _y) {
       }

include/dagShortestPath/pgr_dagShortestPath.hpp

@@ -48,6 +48,8 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 #include "c_types/ii_t_rt.h"
 
+namespace pgrouting {
+
 template < class G >
 class Pgr_dag {
  public:
@@ -360,4 +362,6 @@ class Pgr_dag {
      };
 };
 
+}  // namespace pgrouting
+
 #endif  // INCLUDE_DAGSHORTESTPATH_PGR_DAGSHORTESTPATH_HPP_

include/vrp/order.h

@@ -47,8 +47,6 @@ class Order : public Identifier {
      Order(size_t p_id, int64_t p_idx,
              const Vehicle_node &p_pickup,
              const Vehicle_node &p_deliver);
-
-     Order(const Order &) = default;
      /*!@}*/
 
 

include/vrp/pd_orders.h

@@ -60,7 +60,6 @@ class PD_Orders {
       * @{
       */
      PD_Orders() = default;
-     PD_Orders(const PD_Orders&) = default;
      explicit PD_Orders(const std::vector<Orders_t>&);
      /*!@}*/
 

include/vrp/tw_node.h

@@ -210,7 +210,6 @@ class Tw_node : public Dnode {
 
 
      Tw_node() = default;
-     Tw_node(const Tw_node &) = default;
      Tw_node(
              size_t id,
              Orders_t data,

include/vrp/vehicle.h

@@ -91,7 +91,6 @@ class Vehicle : public Identifier {
      std::vector<Schedule_rt>
            get_postgres_result(int vid) const;
 
-     Vehicle(const Vehicle &) = default;
      Vehicle(
              size_t idx,
              int64_t id,

include/vrp/vehicle_node.h

@@ -145,7 +145,6 @@ class Vehicle_node: public Tw_node {
 
      /*! \brief Construct from parameters */
      Vehicle_node() = delete;
-     Vehicle_node(const Vehicle_node &) = default;
      explicit Vehicle_node(const Tw_node &node);
 
  private:

include/vrp/vehicle_pickDeliver.h

@@ -67,9 +67,6 @@ class Vehicle_pickDeliver : public Vehicle {
              double p_speed,
              double factor);
 
-     Vehicle_pickDeliver(const Vehicle_pickDeliver &) = default;
-
-
      void set_compatibles(const PD_Orders &orders);
      bool is_order_feasable(const Order &order) const;
      Identifiers<size_t> feasable_orders() const {return m_feasable_orders;}