Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add approved session keys to registry script #21

Merged
merged 7 commits into from
Mar 5, 2025

Conversation

jarrodwatts
Copy link
Collaborator

@jarrodwatts jarrodwatts commented Feb 28, 2025

PR-Codex overview

This PR introduces a new script to add approved session keys to a registry, enhancing the management of session key policies. It also updates the package.json and defines new policy configurations.

Detailed summary

  • Added add-approved-session-keys-to-registry script in package.json.
  • Created deploy/add-approved-session-keys-to-registry.ts to handle session key approvals.
  • Defined new enums and interfaces in deploy/const/session-key-configs.ts for policy types and configurations.
  • Implemented logic to check roles and process various policy configurations.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@jarrodwatts jarrodwatts requested a review from coffeexcoin March 3, 2025 21:21
Copy link
Contributor

@coffeexcoin coffeexcoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall; a few suggestions

@coffeexcoin coffeexcoin merged commit 0ad51cf into main Mar 5, 2025
1 check failed
@cygaar cygaar deleted the jw/add-session-key-script branch March 7, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants