Update osmosis tests(with modified wasm) #518

Buckram123 · 2024-10-30T11:36:14Z

Alternative to #512

Here we use build script to change creator, instead of adding a new feature.

From the user perspective.
This approach:

have to set ABSTRACT_CREATOR environment to seed or public key bytes before compiling the contract
all of the contract dependencies(for example dex adapter) should be compiled with same ABSTRACT_CREATOR
No indication if the wasm was built with or without custom ABSTRACT_CREATOR

Have to set feature on abstract-MODULE and all of the abstract module dependencies (for example dex adapter)
Have to have same feature name as enabled in abstract-MODULE (right now feature named mock-deployment)
Have to add mock build inside [package.metadata.optimizer] section
Two sets of the wasm, mock deployment is clearly visible

It's not a final, before I finish would be nice to have final approve on one of the methods
TODO, if this method gets approved:

Figure out where we want to set the ENV. Currently I like setting it in .cargo/config.toml#env section, because this file usually public and also will be moved inside docker(so no need to set it separately for the docker), but it's easy to deploy the wrong version this way
If we rely on custom ABSTRACT_CREATOR in tests, tests that use wasms, will fail in release version, are we fine with that, anything we can do with it?

…s-tests

…is-test-with-modified-wasm

…s-test-with-modified-wasm

framework/contracts/native/registry/src/contract.rs

framework/contracts/native/registry/src/migrate.rs

Buckram123 · 2024-10-30T11:43:44Z

framework/packages/abstract-interface/build.rs

+        let public_key = bip32::Mnemonic::new(&creator, Default::default())
+            .map(|phrase| {
+                let seed = phrase.to_seed("");
+                let derive_path: bip32::DerivationPath = "m/44'/118'/0'/0/0".parse().unwrap();


Do we have to add coin_type or derive_path as another env? IMO it's an overkill until someone needs it

Buckram123 · 2024-10-30T11:45:47Z

framework/packages/abstract-interface/src/deployment.rs

            native_addrs::creator_address(hrp)?,
            "Only predetermined abstract admin can deploy abstract contracts, see `native_addrs.rs`"
        );
-
-        let admin = sender_addr.to_string();
-        // upload
-        let mut deployment = Self::store_on(chain.clone())?;
-        let blob_code_id = deployment.blob.code_id()?;
-
-        let creator_account_id: cosmrs::AccountId = admin.as_str().parse().unwrap();
-        let canon_creator = CanonicalAddr::from(creator_account_id.to_bytes());
-
-        let expected_addr = |salt: &[u8]| -> Result<CanonicalAddr, Instantiate2AddressError> {
-            instantiate2_address(&cw_blob::CHECKSUM, &canon_creator, salt)
-        };
-
-        deployment.ans_host.deterministic_instantiate(
-            &abstract_std::ans_host::MigrateMsg::Instantiate(
-                abstract_std::ans_host::InstantiateMsg {
-                    admin: admin.to_string(),
-                },
-            ),
-            blob_code_id,
-            expected_addr(native_addrs::ANS_HOST_SALT)?,
-            Binary::from(native_addrs::ANS_HOST_SALT),
-        )?;
-
-        deployment.registry.deterministic_instantiate(
-            &abstract_std::registry::MigrateMsg::Instantiate(
-                abstract_std::registry::InstantiateMsg {
-                    admin: admin.to_string(),
-                    #[cfg(feature = "integration")]
-                    security_disabled: Some(true),
-                    #[cfg(not(feature = "integration"))]
-                    security_disabled: Some(false),
-                    namespace_registration_fee: None,
-                },
-            ),
-            blob_code_id,
-            expected_addr(native_addrs::REGISTRY_SALT)?,
-            Binary::from(native_addrs::REGISTRY_SALT),
-        )?;
-        deployment.module_factory.deterministic_instantiate(
-            &abstract_std::module_factory::MigrateMsg::Instantiate(
-                abstract_std::module_factory::InstantiateMsg {
-                    admin: admin.to_string(),
-                },
-            ),
-            blob_code_id,
-            expected_addr(native_addrs::MODULE_FACTORY_SALT)?,
-            Binary::from(native_addrs::MODULE_FACTORY_SALT),
-        )?;
-
-        // We also instantiate ibc contracts
-        deployment.ibc.client.deterministic_instantiate(
-            &abstract_std::ibc_client::MigrateMsg::Instantiate(
-                abstract_std::ibc_client::InstantiateMsg {},
-            ),
-            blob_code_id,
-            expected_addr(native_addrs::IBC_CLIENT_SALT)?,
-            Binary::from(native_addrs::IBC_CLIENT_SALT),
-        )?;
-        deployment.ibc.host.deterministic_instantiate(
-            &abstract_std::ibc_host::MigrateMsg::Instantiate(
-                abstract_std::ibc_host::InstantiateMsg {},
-            ),
-            blob_code_id,
-            expected_addr(native_addrs::IBC_HOST_SALT)?,
-            Binary::from(native_addrs::IBC_HOST_SALT),
-        )?;
-        deployment.ibc.register(&deployment.registry)?;
-
-        deployment.registry.register_base(&deployment.account)?;
-        deployment
-            .registry
-            .register_natives(deployment.contracts())?;
-        deployment.registry.approve_any_abstract_modules()?;
-
-        // Create the first abstract account in integration environments
-        #[cfg(feature = "integration")]
-        use abstract_std::objects::gov_type::GovernanceDetails;
-        #[cfg(feature = "integration")]
-        AccountI::create_default_account(
-            &deployment,
-            GovernanceDetails::Monarchy {
-                monarch: chain.sender_addr().to_string(),
-            },
-        )?;
+        let mut deployment = Self::_deploy(&chain)?;


Was thinking about having second deploy function, like mock_deploy, where we allow changing creator, and in default we check if creator matches to the original

Buckram123 · 2024-10-30T11:47:29Z

modules/contracts/adapters/dex/tests/osmosis.rs

+const MOCK_MNEMONIC: &str = "clip hire initial neck maid actor venue client foam budget lock catalog sweet steak waste crater broccoli pipe steak sister coyote moment obvious choose";
+


we can get it from env, but what do we do if it's not set?

cloudflare-workers-and-pages · 2024-10-30T12:26:10Z

Deploying abstract-docs with Cloudflare Pages

Latest commit:	`3d06f9b`
Status:	✅ Deploy successful!
Preview URL:	https://ac36e985.abstract-docs.pages.dev
Branch Preview URL:	https://buckram-update-osmosis-test.abstract-docs.pages.dev

View logs

Buckram123 · 2024-11-11T17:51:18Z

Closed in favor #528

Buckram123 added 16 commits October 24, 2024 15:40

update osmosis tests

18f3397

unused dep

016f9fc

update hakari

fef1b4d

mock-deployment for apps/adapters wasm

69e620d

Merge remote-tracking branch 'origin/main' into buckram/update-osmosi…

afcb4a1

…s-tests

remove patch section

f237470

build.rs scripts

610dadf

update build script for abstract-interface

95aaf19

out only wasms, without checksum txt

481bebd

move comment

605139e

Merge branch 'buckram/update-osmosis-tests' into buckram/update-osmos…

094835f

…is-test-with-modified-wasm

Merge remote-tracking branch 'origin/main' into buckram/update-osmosi…

1879f5f

…s-test-with-modified-wasm

setting env in cargo/config.toml

e481ef5

checksums

3b7690b

update expect message on ABSTRACT_CREATOR

af97fa2

fix registry rev namespace for abstract

24613ed

Buckram123 requested a review from CyberHoward October 30, 2024 11:36

github-actions bot added adapter_base interface native labels Oct 30, 2024

Buckram123 commented Oct 30, 2024

View reviewed changes

clippy, remove changes to creator_public_key

3d06f9b

Buckram123 mentioned this pull request Nov 4, 2024

Rev namespace for abstract #524

Merged

Kayanski mentioned this pull request Nov 11, 2024

Update osmosis tests, using code id to predict addresses #528

Merged

Buckram123 closed this Nov 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update osmosis tests(with modified wasm) #518

Update osmosis tests(with modified wasm) #518

Buckram123 commented Oct 30, 2024 •

edited

Loading

Buckram123 Oct 30, 2024

Buckram123 Oct 30, 2024 •

edited

Loading

Buckram123 Oct 30, 2024

cloudflare-workers-and-pages bot commented Oct 30, 2024 •

edited

Loading

Buckram123 commented Nov 11, 2024

		const MOCK_MNEMONIC: &str = "clip hire initial neck maid actor venue client foam budget lock catalog sweet steak waste crater broccoli pipe steak sister coyote moment obvious choose";

Update osmosis tests(with modified wasm) #518

Update osmosis tests(with modified wasm) #518

Conversation

Buckram123 commented Oct 30, 2024 • edited Loading

Buckram123 Oct 30, 2024

Choose a reason for hiding this comment

Buckram123 Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

Buckram123 Oct 30, 2024

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Oct 30, 2024 • edited Loading

Deploying abstract-docs with Cloudflare Pages

Buckram123 commented Nov 11, 2024

Buckram123 commented Oct 30, 2024 •

edited

Loading

Buckram123 Oct 30, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 30, 2024 •

edited

Loading