Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending ICS20 messages with callbacks #527

Merged
merged 23 commits into from
Nov 18, 2024
Merged

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Nov 5, 2024

This PR aims at implementing ICS20 sends with actions. It adds a new cosmwasm endpoint to the ibc-client contract, and enables ibc-client on accounts by default

Changes

  • Ibc Client is now whitelisted by default

Checklist

  • CI is green.
  • Changelog updated.

@Kayanski Kayanski changed the title Implementation of sending a message Sending ICS20 messages with callbacks Nov 5, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 5, 2024

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a733c5d
Status:⚡️  Build in progress...

View logs

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 2.77778% with 140 lines in your changes missing coverage. Please review.

Project coverage is 73.0%. Comparing base (bf989a9) to head (74335a9).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
framework/contracts/account/src/contract.rs 0.0% 47 Missing ⚠️
framework/contracts/account/src/execution.rs 0.0% 40 Missing ⚠️
...contracts/native/ibc-host/src/endpoints/execute.rs 0.0% 31 Missing ⚠️
framework/contracts/account/src/reply.rs 0.0% 16 Missing ⚠️
framework/packages/abstract-std/src/account.rs 0.0% 6 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
framework/contracts/account/src/lib.rs 100.0% <ø> (ø)
.../contracts/native/ibc-host/src/account_commands.rs 97.6% <100.0%> (+<0.1%) ⬆️
.../contracts/native/ibc-host/src/endpoints/packet.rs 83.2% <100.0%> (+0.2%) ⬆️
...contracts/native/ica-client/src/chain_types/evm.rs 97.2% <ø> (ø)
...amework/contracts/native/ica-client/src/queries.rs 95.3% <ø> (ø)
framework/packages/abstract-std/src/native/ibc.rs 60.4% <ø> (ø)
...k/packages/abstract-std/src/native/ibc/ibc_host.rs 76.9% <ø> (-7.7%) ⬇️
framework/packages/abstract-std/src/account.rs 74.1% <0.0%> (-17.9%) ⬇️
framework/contracts/account/src/reply.rs 63.6% <0.0%> (-26.2%) ⬇️
...contracts/native/ibc-host/src/endpoints/execute.rs 47.4% <0.0%> (-31.3%) ⬇️
... and 2 more

... and 19 files with indirect coverage changes

Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

framework/contracts/account/src/reply.rs Outdated Show resolved Hide resolved
framework/packages/abstract-std/src/account.rs Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Kayanski Kayanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some nice comments on this PR,
T
Keep in mind that the changes on the accounts need to be minimal here, there is almost nothing to change there (expect the IBC CLient whitelist)

framework/contracts/account/src/contract.rs Outdated Show resolved Hide resolved
framework/contracts/account/src/execution.rs Outdated Show resolved Hide resolved
framework/contracts/account/tests/token_transfers.rs Outdated Show resolved Hide resolved
@Kayanski Kayanski marked this pull request as ready for review November 18, 2024 10:36
@Kayanski Kayanski merged commit 85ce6d2 into main Nov 18, 2024
5 of 8 checks passed
@Kayanski Kayanski deleted the feature/account-ics20-actions branch November 18, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants