Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added disconnect script #547

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Added disconnect script #547

merged 6 commits into from
Nov 27, 2024

Conversation

Kayanski
Copy link
Contributor

Checklist

  • CI is green.
  • Changelog updated.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 26, 2024 •
edited
Loading

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0f01b3b
Status:⚡️  Build in progress...

View logs

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 74.3%. Comparing base (bf989a9) to head (bab1316).
Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
framework/packages/abstract-interface/src/ibc.rs 0.0% 24 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
framework/packages/abstract-interface/src/ibc.rs 59.6% <0.0%> (-11.3%) ⬇️

... and 85 files with indirect coverage changes

@Kayanski Kayanski requested a review from Buckram123 November 26, 2024 10:35
adairrr
adairrr approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@adairrr adairrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, otherwise if it works lgtm.

interchain/scripts/src/bin/ibc_disconnect.rs Outdated Show resolved Hide resolved
interchain/scripts/src/bin/ibc_disconnect.rs Outdated Show resolved Hide resolved
interchain/scripts/src/bin/ibc_disconnect.rs Outdated Show resolved Hide resolved
@Kayanski Kayanski merged commit 26839e6 into main Nov 27, 2024
11 of 13 checks passed
@Kayanski Kayanski deleted the add/ibc-disconnect-script branch November 27, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adairrr adairrr adairrr approved these changes

@Buckram123 Buckram123 Awaiting requested review from Buckram123

Assignees
No one assigned
Labels
interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kayanski @adairrr