Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update and when update fields are non empty #562

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Jan 6, 2025

Checklist

  • CI is green.
  • Changelog updated.

Copy link

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9ff1132
Status: ✅  Deploy successful!
Preview URL: https://3befc38c.abstract-docs.pages.dev
Branch Preview URL: https://nicolas-abs-592-update-ans-w.abstract-docs.pages.dev

View logs

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.7%. Comparing base (bf989a9) to head (9ff1132).
Report is 88 commits behind head on main.

Files with missing lines Patch % Lines
framework/packages/abstract-client/src/builder.rs 80.0% 3 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
framework/packages/abstract-client/src/builder.rs 66.2% <80.0%> (-1.8%) ⬇️

... and 94 files with indirect coverage changes

Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Took small glance at implementations, and noticed that we can do another small gas optimization, on contract side. update_dex_registry loads REGISTERED_DEXES twice in case both to_add and to_remove isn't empty.

@Kayanski
Copy link
Contributor Author

Kayanski commented Jan 7, 2025

Nice! Took small glance at implementations, and noticed that we can do another small gas optimization, on contract side. update_dex_registry loads REGISTERED_DEXES twice in case both to_add and to_remove isn't empty.

As this function won't be triggered too much, I think it's ok to keep it that way, plus it's nice right now haha

@Kayanski Kayanski merged commit 97de5a8 into main Jan 7, 2025
15 of 16 checks passed
@Kayanski Kayanski deleted the nicolas/abs-592-update_ans-wastes-gas-with-zero-length-updates branch January 7, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants