fix: fix incorrect vertical alignment in text render

The y argument in OIIO::ImageBufAlgo::render_text() should represent the top and bottom edge of the text if vertical alignment is set to TextAlignY::Top and TextAlignY::Bottom. However currently the rendered text is off. The current code adjusts y to point to the top of the text box before rendering the text, but it has to be adjusted to point to the baseline of the text. There is a current test case, testing vertical alignment, but the reference image seems wrong and has now been updated. Signed-off-by: peter.horvath <[email protected]>
AcademySoftwareFoundation · Oct 24, 2024 · 088332d · 088332d
1 parent 4b8accf
commit 088332d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/libOpenImageIO/imagebufalgo_draw.cpp b/src/libOpenImageIO/imagebufalgo_draw.cpp
@@ -1104,9 +1104,9 @@ ImageBufAlgo::render_text(ImageBuf& R, int x, int y, string_view text,
     if (alignx == TextAlignX::Center)
         x -= (textroi.width() / 2 + textroi.xbegin);
     if (aligny == TextAlignY::Top)
-        y += textroi.height();
+        y -= textroi.ybegin;
     if (aligny == TextAlignY::Bottom)
-        y -= textroi.height();
+        y -= textroi.yend;
     if (aligny == TextAlignY::Center)
         y -= (textroi.height() / 2 + textroi.ybegin);
 

diff --git a/testsuite/oiiotool-text/ref/aligned.tif b/testsuite/oiiotool-text/ref/aligned.tif