fix(exr): allow an empty "name" metadata to be read #4536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuation of PR AcademySoftwareFoundation#4528. I forgot to change the spot in the OpenEXR "core" API as well. Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 12, 2024
…oundation#4536) Continuation of PR AcademySoftwareFoundation#4528. I forgot to change the spot in the OpenEXR "core" API as well. Signed-off-by: Larry Gritz <[email protected]>
|
LGTM! (commenting since I saw you wanted to move away from no reviews) |
|
Thank you! Yes, please, it was never our intention to merge review-less PRs, outside of true necessity, but I'm afraid the habit started to grow over time. But now we're trying to re-emphasize that it is undesirable. At the very least, having a second pair of eyes doing even a very cursory look before a merge ensures that no one person (including one trusted person whose credentials are stolen) can easily sneak problems into the repo -- something has actually happened to cause some high-profile debacles in other projects. |
|
Glad to help! Even if it's not through direct commits :) |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 15, 2024
…oundation#4536) Continuation of PR AcademySoftwareFoundation#4528. I forgot to change the spot in the OpenEXR "core" API as well. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #4528. I forgot to change the spot in the OpenEXR "core" API as well.