Add "click-and-drag-to-buy" feature to upgrades #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I originally implemented this for pg132s Tree of Life, but I thought it could be nice to have in base as well)
This PR adds a "click-and-drag-to-buy" feature to upgrades, i.e. you can buy all upgrades in a layer by holding down the left mouse button and dragging your mouse over the buttons. Only one event is fired per element, so no performance regression.
The only unfortunate change is that you can no longer cancel buying an upgrade, i.e. click the button, drag the mouse away and release it, since this will buy on
mousedowninstead ofmouseupas previously. If you want I think it should be easy to implement it so you only buy the current upgrade if you do mouseup on it or drag the mouse onto another unbought upgrade, so you could always cancel by dragging onto a bought upgrade or the empty space, but this behavior might be a bit confusing.