Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add factorial with while loop #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hasangenc0
Copy link

@hasangenc0 hasangenc0 commented Feb 8, 2020

related with #29
This is my solution to the top of the others.

@codecov-io
Copy link

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #30   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         201    207    +6     
  Branches       36     35    -1     
=====================================
+ Hits          201    207    +6
Impacted Files Coverage Δ
src/functions/factorial.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64af1d0...5bca8cd. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        14    -4     
  Lines          280       207   -73     
  Branches        41        35    -6     
=========================================
- Hits           280       207   -73     
Impacted Files Coverage Δ
src/functions/factorial.ts 100.00% <100.00%> (ø)
src/functions/max.ts 100.00% <0.00%> (ø)
src/functions/index.ts 100.00% <0.00%> (ø)
src/functions/times.ts 100.00% <0.00%> (ø)
src/functions/average.ts 100.00% <0.00%> (ø)
src/functions/is-array.ts 100.00% <0.00%> (ø)
src/functions/is-number.ts 100.00% <0.00%> (ø)
src/functions/is-string.ts 100.00% <0.00%> (ø)
src/functions/is-undefined.ts
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d8980...bbdabd2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants