Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for preferences window #279

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Various fixes for preferences window #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccfed2c
use label instead of placeholder text
Sep 23, 2024
defe90a
various fixes in the preferences window
Sep 23, 2024
3f0d18c
taller-prefs-window
Sep 23, 2024
a0bcdf7
Revert "use label instead of placeholder text"
Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion data/resources/ui/preferences/dir_row.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@
<property name="hexpand">true</property>
<child>
<object class="GtkBox">
<property name="spacing">8</property>
<child>
<object class="GtkButton">
<property name="margin-top">6</property>
<property name="margin-bottom">6</property>
<property name="action-name">dir_row.up</property>
<property name="icon-name">go-up-symbolic</property>
<property name="valign">center</property>
</object>
</child>
<child>
Expand All @@ -20,6 +22,7 @@
<property name="margin-bottom">6</property>
<property name="action-name">dir_row.down</property>
<property name="icon-name">go-down-symbolic</property>
<property name="valign">center</property>
</object>
</child>
<child>
Expand All @@ -28,9 +31,10 @@
<property name="margin-bottom">6</property>
<property name="action-name">dir_row.remove</property>
<property name="icon-name">list-remove</property>
<property name="valign">center</property>
</object>
</child>
</object>
</child>
</template>
</interface>
</interface>
98 changes: 53 additions & 45 deletions data/resources/ui/preferences/preferences.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<interface>
<!-- TODO: Migrate to AdwPreferencesDialog since AdwPreferencesWindow is deprecated-->
<template class="PreferencesWindow" parent="AdwPreferencesWindow">
<property name="default-width">820</property>
<property name="default-height">760</property>
<property name="default-width">500</property>
<property name="default-height">610</property>
<child>
<object class="AdwPreferencesPage">
<property name="icon-name">applications-system-symbolic</property>
Expand All @@ -13,11 +14,12 @@
<property name="title" translatable="yes">Startup</property>
<child>
<object class="AdwActionRow">
<property name="title" translatable="yes">_Default view</property>
<property name="title" translatable="yes">_Startup tab</property>
<property name="use-underline">True</property>
<property name="activatable-widget">default_view_selection</property>
<property name="subtitle" translatable="yes">What panel to open the application on</property>
<property name="subtitle" translatable="yes">What tab the application starts on</property>
<child>
<!-- TODO: Migrate to AdwComboRow since GtkComboBoxText is deprecated -->
<object class="GtkComboBoxText" id="default_view_selection">
<property name="valign">center</property>
<property name="active-id">library</property>
Expand Down Expand Up @@ -130,27 +132,17 @@
<property name="subtitle" translatable="yes">Where asset info files will be stored</property>
<child>
<object class="GtkButton">
<property name="action-name">preferences.cache</property>
<property name="margin-start">6</property>
<property name="margin-end">6</property>
<property name="margin-top">6</property>
<property name="margin-bottom">6</property>
<property name="action-name">preferences.cache</property>
<property name="valign">center</property>
<child>
<object class="GtkBox">
<property name="spacing">5</property>
<child>
<object class="GtkImage">
<property name="can-focus">0</property>
<property name="icon-name">folder-templates</property>
</object>
</child>
<child>
<object class="GtkLabel">
<property name="can-focus">0</property>
<property name="label" translatable="yes">Change</property>
</object>
</child>
</object>
<object class="AdwButtonContent">
<property name="icon-name">folder-templates-symbolic</property>
<property name="label" translatable="yes">Change</property>
</object>
</child>
</object>
</child>
Expand All @@ -163,27 +155,17 @@
<property name="subtitle" translatable="yes">Temporary place for chunk downloads</property>
<child>
<object class="GtkButton">
<property name="action-name">preferences.temp</property>
<property name="margin-start">6</property>
<property name="margin-end">6</property>
<property name="margin-top">6</property>
<property name="margin-bottom">6</property>
<property name="action-name">preferences.temp</property>
<property name="valign">center</property>
<child>
<object class="GtkBox">
<property name="spacing">5</property>
<child>
<object class="GtkImage">
<property name="can-focus">0</property>
<property name="icon-name">folder-download</property>
</object>
</child>
<child>
<object class="GtkLabel">
<property name="can-focus">0</property>
<property name="label" translatable="yes">Change</property>
</object>
</child>
</object>
<object class="AdwButtonContent">
<property name="icon-name">folder-download-symbolic</property>
<property name="label" translatable="yes">Change</property>
</object>
</child>
</object>
</child>
Expand All @@ -209,7 +191,15 @@
<child>
<object class="GtkButton">
<property name="action-name">preferences.add_vault</property>
<property name="label" translatable="yes">Add new</property>
<property name="margin-top">6</property>
<property name="margin-bottom">6</property>
<property name="margin-end">6</property>
<child>
<object class="AdwButtonContent">
<property name="icon-name">list-add-symbolic</property>
<property name="label" translatable="yes">Add location</property>
</object>
</child>
</object>
</child>
</object>
Expand All @@ -231,7 +221,15 @@
<child>
<object class="GtkButton">
<property name="action-name">preferences.add_engine</property>
<property name="label" translatable="yes">Add new</property>
<property name="margin-top">6</property>
<property name="margin-bottom">6</property>
<property name="margin-end">6</property>
<child>
<object class="AdwButtonContent">
<property name="icon-name">list-add-symbolic</property>
<property name="label" translatable="yes">Add location</property>
</object>
</child>
</object>
</child>
</object>
Expand All @@ -253,7 +251,15 @@
<child>
<object class="GtkButton">
<property name="action-name">preferences.add_project</property>
<property name="label" translatable="yes">Add new</property>
<property name="margin-top">6</property>
<property name="margin-bottom">6</property>
<property name="margin-end">6</property>
<child>
<object class="AdwButtonContent">
<property name="icon-name">list-add-symbolic</property>
<property name="label" translatable="yes">Add location</property>
</object>
</child>
</object>
</child>
</object>
Expand Down Expand Up @@ -295,13 +301,14 @@
</child>
<child>
<object class="GtkLabel">
<property name="wrap">true</property>
<property name="label" translatable="yes">&lt;b&gt;&lt;big&gt;How to obtain the token&lt;/big&gt;&lt;/b&gt;
1. Validate you have access to the &lt;a href="https://github.com/EpicGames/UnrealEngine"&gt;Unreal Engine&lt;/a&gt; repository. (&lt;a href="https://www.unrealengine.com/en-US/ue4-on-github"&gt;How to obtain?&lt;/a&gt;)
2. Go to your GitHub Settings → Developer settings → &lt;a href="https://github.com/settings/tokens"&gt;Personal access tokens&lt;/a&gt;
3. Generate new token
4. Set expiration to something reasonable
5. You only need the &lt;u&gt;read:packages&lt;/u&gt; scope for our use
6. Copy the generated token into the field above
1. Validate you have access to the &lt;a href="https://github.com/EpicGames/UnrealEngine"&gt;Unreal Engine&lt;/a&gt; repository. (&lt;a href="https://www.unrealengine.com/en-US/ue4-on-github"&gt;How to obtain?&lt;/a&gt;)
2. Go to your GitHub Settings → Developer settings → &lt;a href="https://github.com/settings/tokens"&gt;Personal access tokens&lt;/a&gt;
3. Generate new token
4. Set expiration to something reasonable
5. You only need the &lt;u&gt;read:packages&lt;/u&gt; scope for our use
6. Copy the generated token into the field above
</property>
<property name="use-markup">true</property>
</object>
Expand All @@ -314,3 +321,4 @@
</child>
</template>
</interface>

Loading