Boxed-list info rows #294
Merged
Boxed-list info rows #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have just one question... why are there 158 modified files?:D |
|
I'm guessing I've somehow accidentally changed chmod permissions from 644 to 755 (on every single file) :P Found this blogpost, going to try to undo it now using his method, hopefully it won't make it worse |
|
Okay, "17 files changed" sounds way better, and it still compiles so I'm counting this as a win |
aknarts
approved these changes
Dec 8, 2024
aknarts
reviewed
Dec 8, 2024
| @@ -230,6 +230,8 @@ impl EpicAssetDetails { | |||
| "close", | |||
| clone!(@weak self as details => move |_, _| { | |||
| details.collapse(); | |||
| println!("FRRR") | |||
There was a problem hiding this comment.
Woopsie, bit of debug code slipped through :P
Will take care of that with the next PR
There was a problem hiding this comment.
Do not worry about it, I removed it while merging it into my branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The projects tab shows these changes best, but the other tabs are also changed.
Before:
After:
The rows are no longer selectable/activatable, but the text inside them is selectable, so it is much easier to copy it. The asset description wasn't fully visible if it was over a certain length, which is fixed with these changes. The logs are much easier to scroll through since it expands all of them, instead of having a scroll window inside a scroll window. Even though this version takes up a bunch more space than before, I think the new rows improve legibility by a lot.
I'm not experienced with rust so it may be worth checking out the changes there for any programming war crimes. (the create_details_row function has been replaced by create_info_row and create_widget_row)
@aknarts This PR is mainly for you to get a look at and see if it breaks anything for the rewrite, not expecting it to get it merged right now.
(Also not sure why git counted 158 file changes)