Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions menu and download pop-up improvements #300

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

PhilippKosarev
Copy link
Contributor

Before

Screenshot From 2024-12-10 23-18-56

After

Screenshot From 2024-12-10 23-26-44

Issues

GtkComboBoxText doesn't seem to have any way of ellipsizing its contents, which can look quite comical with long paths. GtkDropDown or AdwComboRow might solve this, but I'm not good with rust so not sure how to do that.
Screenshot From 2024-12-10 23-48-16

GtkComboBoxText is also misplaced until an item is selected, afaik GtkDropDown and AdwComboRow don't have this problem.
image

Local files row for some reason has a clickable element, even though it's just a GtkBox.
image

All of the actions now do the same thing, but the code doesn't reflect that because I'm not sure how to fix that without crashing the app.
image

download_item.rs is also quite messy :P

@Catley94
Copy link

I like this! It goes well with some changes that I also made and about to do a PR for. I am also not a rust expert, I've just picked away at a few bits to make it look a little cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants