Actions menu and download pop-up improvements #300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Issues
GtkComboBoxText doesn't seem to have any way of ellipsizing its contents, which can look quite comical with long paths. GtkDropDown or AdwComboRow might solve this, but I'm not good with rust so not sure how to do that.
GtkComboBoxText is also misplaced until an item is selected, afaik GtkDropDown and AdwComboRow don't have this problem.
Local files row for some reason has a clickable element, even though it's just a GtkBox.
All of the actions now do the same thing, but the code doesn't reflect that because I'm not sure how to fix that without crashing the app.
download_item.rs
is also quite messy :P