Add automated tests #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molecule/default/converge.yml
Outdated
| pre_tasks: | ||
|
|
||
| - name: Install nginx | ||
| apt: |
There was a problem hiding this comment.
You'll need to either use "package" instead of "apt" (will only works if the package is the same name on both OS'es), or split this into OS-specific versions.
molecule/default/converge.yml
Outdated
| become: true | ||
|
|
||
| vars: | ||
| - default_mail_recipient: [email protected] |
There was a problem hiding this comment.
Please use fictional values instead.
molecule/default/prepare.yml
Outdated
| - name: Ensure python is installed | ||
| package: | ||
| name: | ||
| - python |
There was a problem hiding this comment.
@Chithrak07 You might need python3 here? Python2 is Dead/EOL. This is just a guess. You'll need to find out for sure what the package name is for RH/CentOS.
molecule/default/prepare.yml
Outdated
Comment on lines
27
to
29
| - name: Ensure nginx is installed for Debian | ||
| apt: pkg=nginx state=present update_cache=true | ||
| when: ansible_os_family == 'Debian' |
There was a problem hiding this comment.
If this task happens to fail, just update apt's cache first by itself before trying to install anything.
molecule/default/prepare.yml
Outdated
| when: ansible_os_family == 'Debian' | ||
|
|
||
| - name: Ensure python is installed for Debian | ||
| apt: pkg=python state=present update_cache=true |
There was a problem hiding this comment.
Same issue here - Python without a version is generally python2 ... we want python3.
…, in order to pass molecule tests
… addresses the new snap-based certbot installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.