-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTI-15742] Close connection after writing the last checkpoint #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tak30
reviewed
Mar 1, 2024
I would be in favour of using a generic timeout just to ensure we really close the socket |
raz-adroll
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can we log something if we receive the shutdown message?
raz-adroll
approved these changes
Mar 4, 2024
pehuen-rodriguez
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close connection after writing the last checkpoint when receiving a terminate event.
This PR adds a state_timeout (see gen_statem state-timeout), this timeout will be cancelled if there's a state change (which will happen if we get a response). If we want to trigger the timeout regardless of state changes, we can use a generic timeout.
The way this timeout works is by inserting the timeout trigger when setting state to
{?PEER_READ, ?SHUTDOWN}
so this timeout will protect us from staleness in both cases of terminate, {ok, Checkpoint}} and {_, ok} in the MLD shutdown handler. Because bothsuccess/3
andshutdown_checkpoint/2
set next state to{?PEER_WRITE, ?SHUTDOWN}
or{?PEER_WRITE, ?SHUTDOWN_CHECKPOINT}
with the{write, IoData}
event.UPDATE:
{?PEER_READ, ?SHUTDOWN}