Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update worksheet.rb #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update worksheet.rb #30

wants to merge 1 commit into from

Conversation

GeMath18
Copy link

Assignment Submission: Ride Share

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Question Answer
What did your data structure look like at first? Did this structure evolve over time? Why? Yes, my data struture changed one time. I had to many extra layers that when i wanted to answer the first question I coudn't answer it. I was making it too complicated. After I changed it started to make sure and was easier to answer questions with code.
What was your strategy for going through the data structure and gathering information? First I needed to make sure I understood the layers and what each data structure represented and how to get to each layer.
What was an example of something that was necessary to store in a variable? Why was it necessary, useful, or helpful? for example when it required to make operations like sum or average. It was better to store in a variable to then later being able to use string interpolation to enter in my string and being part of the answer .
What kinds of iteration did you use? Did you use .map? If so, when? If not, why, or when would be a good opportunity to use it? I did use map in many of my answers because it was a method where i can create a new array/hash that had the same length elements of the original, and I could apply any operations to each element and not changing the original.
Were some calculations easier than others? Why? yes, the part where I needed extra help were questions 4 and 5. I needed to be able to create another hash or array to isolate the information of one driver looking for who made the most money or had the best rating. After I was able to figure out question 4. It was easier to apply the same concept to question 5.

Copy link

@kaidamasaki kaidamasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Your solution is clean and you made good use of enumerable methods!

Ride Share

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates, reads, and modifies variables ✔️
Correctly creates and accesses arrays ✔️
Correctly creates and accesses hashes ✔️
Reasonably organizes large amounts of related data into nested arrays and hashes ✔️
Correctly iterates through a nested data structure using loops and/or Enumerable methods ✔️
Reasonably organizes small pieces of code into methods, and calls/invokes those methods ✔️

Functional Requirements

Functional Requirement yes/no
To the terminal, the program outputs the correct number of rides each driver has given ✔️
... outputs the total amount of money each driver has made ✔️
... outputs the average rating for each driver ✔️
... outputs which driver made the most money ✔️
... outputs which driver has the highest average rating ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 2-3 in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0,1 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Comment on lines +136 to +138
number_of_rides = driver_id.map do |key, value|
"Driver with ID: #{key} made #{value.length} rides. "
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funky indentation.

Suggested change
number_of_rides = driver_id.map do |key, value|
"Driver with ID: #{key} made #{value.length} rides. "
end
number_of_rides = driver_id.map do |key, value|
"Driver with ID: #{key} made #{value.length} rides. "
end

Comment on lines +168 to +173
sum = trips.sum do |trip|
trip[:cost]
end
{ total_money: sum, driver_id: key}
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job combining map and sum here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants