forked from AdaGold/api-muncher
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maya Wang's otter-muncher #75
Open
mayawang
wants to merge
52
commits into
Ada-C6:master
Choose a base branch
from
mayawang:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baseline Completed
baseline suppliment
Search feature - completed
…s. result count and last_page not ideal. can improve later
List view- completed
show view - completed
…c logic for diet label sample and health label sample. Does not work yet. Switch to mw_show_view to add health label to show to make manuel test easier
…result found, hits=[]
Limit search optional - completed
…page(need backend functionde improve). Dlete import app.css
…filter search view(checkboxes alignment)
styling - completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heroku live: https://otter-muncher.herokuapp.com/
completed all search, search result and show features using API
filter search feature by health label and diet label using checkbox
manually coded pagination feature without use gem
change return recipe result to 9 per page for better display(which can be easily changed to any number in PAGE_SIZE in api wrapper).
added API attribution in footer
foundation framework: responsive, pagination, label, table, checkbox, go back button, sea otter theme design.
Did not attempt Google OAuth and save favorite feature this time due to time constrain. I did briefly think about how to implement these features.
under construction: testing on API and controller. I will update and merge my testing branch later.