Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya Wang's otter-muncher #75

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

Maya Wang's otter-muncher #75

wants to merge 52 commits into from

Conversation

mayawang
Copy link

@mayawang mayawang commented Nov 7, 2016

heroku live: https://otter-muncher.herokuapp.com/

  • completed all search, search result and show features using API

  • filter search feature by health label and diet label using checkbox

  • manually coded pagination feature without use gem

    • Can show a 'sliding' pagination bar for previous 5 and next 5 pages to handle 1000+ results if needed. Knowing our developer account can only return a limited number of 100 recipes, I commented out this part for better user experience.
    • When implement the +5 and -5 pagination bar, it is hard to stop pagination without reaching the last page because the API does not return a finite number for search result(1000 and more).
    • I will try to implement pagination gem next time as it seems to handle better on the above described last page pagination situation
  • change return recipe result to 9 per page for better display(which can be easily changed to any number in PAGE_SIZE in api wrapper).

  • added API attribution in footer

  • foundation framework: responsive, pagination, label, table, checkbox, go back button, sea otter theme design.

  • Did not attempt Google OAuth and save favorite feature this time due to time constrain. I did briefly think about how to implement these features.

    • Google OAuth: will be similar to Github OAuth. will be nice to go through it if has the opportunity.
    • Save favorites: create user and favorites model. model relation: User has many favorites. I can save and access user & favorites by sessions[user_id].
  • under construction: testing on API and controller. I will update and merge my testing branch later.

Maya Wang added 30 commits October 31, 2016 15:49
Search feature - completed
…s. result count and last_page not ideal. can improve later
…c logic for diet label sample and health label sample. Does not work yet. Switch to mw_show_view to add health label to show to make manuel test easier
Limit search optional - completed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants