Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kelly Tran: Hungry Cook What? #92

Open
wants to merge 23 commits into
base: b/kelly_tran/master
Choose a base branch
from

Conversation

KellyPT
Copy link

@KellyPT KellyPT commented Nov 8, 2016

  • I've completed all baseline requirements.
  • I used Kaminari gem to handle pagination (documentation: https://github.com/amatsuda/kaminari). Prior to this decision, I explored will_paginate/api-pagination/api-pager gems but they all didn't work. Lesson learned: go FIRST with a gem that has detailed documentation because it will help me debug more easily.
  • I think up to this project, I've become more comfortable with Foundation CSS.
  • My test coverage is 100%. I think Dan's TDD lecture on Nov 7 really helped me with this test exercise.
  • I spent a lot of time playing around with memoization. My method worked but were considered "illegitimate" by Dan. I did research on sessions/cookies and tried various ways for 7 hours. Realizing that this was too much time investment, I abandoned memoization altogether. Sorry Edamam! :-|
  • It was a tough week as I was down with stomach flu.

…ing method in api wrapper. Added 2 reset functions to handle cookies.
…ather than calling API from APIwrapper, remove :recipe from class << self method and reset_one method
…to gitignore. Added API ID and key to API wrapper.
…other methods in recipe.rb model and kept only the contructor. The reason is I don't want to deal with data memorized in my browser and reset them every time I conduct a new search. Added Foundation Grid in index page and put thumbnails class and button success/alert class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant