pipes | tanisha | backtrek

[tanham]

BackTREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What role does the Model play in Backbone?	the model keeps track of data, logic and validations
How did the presence of Models and Collections change the way you thought about your app?	it helped to me to organize code
How do Backbone Events compare to DOM events?	It seems that many of the backbone events performed on the model. For example, achieving backbone's .add functionality without backbone would have taken a lot more code.
How did you approach filtering? What was your data flow for this feature?
What do you think of Backbone in comparison to raw JavaScript & jQuery?	I think it's a helpful addition to my Javascript development toolkit.
Do you have any recommendations on how we could improve this project for the next cohort?	no

[kariabancroft]

BackTREK

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Looks good overall - It wouldn't hurt to use some more explicit descriptions in your commit messages.
Comprehension questions	Looks good
Organization
Models and collections are defined in separate files	Yes
Code that relies on the DOM is located in or called by $(document).ready	Yes - looks good
Code follows the Backbone data flow (DOM event -> update model or collection -> Backbone event -> update DOM)	Yes
Functionality
Display list of trips	Good
Display trip details	Good
Register for a trip	I see your note about a bug within the renderReserve function not firing on submit. It could be an instance where the eventHandler is attached to an element before it is present within the DOM. I'm also curious why you didn't pass renderReserve directly into the event handler, rather than creating an arrow function around it (Maybe for debugging purposes?)
Add a trip	Looks good
Sort trips	Good
General
Snappy visual feedback for user actions	Yes
API error handling	You have an error function that you created when fetching the trip data but you don't do anything useful with it - missed opportunity! You do have error handling on trip saving which is good. That outputValidationFailures function seems to nicely constructed though I agree with your assessment that you could've used an underscore template.
Client-side validation	Yes
Overall	Overall you were able to hit the major learning goals of this assignment.