Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sara Chandler -- Carets #30

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

SaraChandler
Copy link

BackTREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone?
How did the presence of Models and Collections change the way you thought about your app?
How do Backbone Events compare to DOM events?
How did you approach filtering? What was your data flow for this feature?
What do you think of Backbone in comparison to raw JavaScript & jQuery?
Do you have any recommendations on how we could improve this project for the next cohort?

@CheezItMan
Copy link

BackTREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Few commits
Comprehension questions MISING
Organization
Models and collections are defined in separate files
Code that relies on the DOM is located in or called by $(document).ready
Code follows the Backbone data flow (DOM event -> update model or collection -> Backbone event -> update DOM)
Functionality
Display list of trips Check
Display trip details MISSING
Register for a trip MISSING
Add a trip MISSING
Sort trips MISSING
General
Snappy visual feedback for user actions Decent start on styling, lots left to do.
API error handling MISSING
Client-side validation MISSING
Overall You're obviously far from done. Let me know if you want to schedule a time and sit down for tutoring. You need to get this complete.

import Backbone from 'backbone';

const Trip = Backbone.Model.extend({

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're going to need a urlRoot field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants