Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carets- Julia Meier #41

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Carets- Julia Meier #41

wants to merge 11 commits into from

Conversation

julmeier
Copy link

@julmeier julmeier commented Dec 4, 2017

BackTREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? The model can set default values for data, validate changes to data, read and write data to the API, and trigger events when the data changes.
How did the presence of Models and Collections change the way you thought about your app? It reminded me of rails app functionality.
How do Backbone Events compare to DOM events? Backbone events include changes to the data, which may not be correlated to DOM events.
How did you approach filtering? What was your data flow for this feature? I did not try to make this optional feature.
What do you think of Backbone in comparison to raw JavaScript & jQuery? I much prefer the latter, based on what we've learned so far...
Do you have any recommendations on how we could improve this project for the next cohort? Reduce scope!!

@kariabancroft
Copy link

BackTREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene For a project spanning several days, you should have many more commits (probably 2x or 3x more)
Comprehension questions Yes
Organization
Models and collections are defined in separate files Yes
Code that relies on the DOM is located in or called by $(document).ready Somewhat - the templates are all within their individual event handlers, but should be created as global variables with the $(document).ready because the DOM might not be populated with the template info within these event handler.
Code follows the Backbone data flow (DOM event -> update model or collection -> Backbone event -> update DOM) Yes - demonstrated at least one example of this with the way renderSingleTrip is used.
Functionality
Display list of trips Good
Display trip details Good
Register for a trip You don't put the URL directly in event handlers anywhere else so why do that when creating a reservation? This is too much information for the event to know - this should be set in the model object like the other cases within the app.
Add a trip Good
Sort trips Yes
General
Snappy visual feedback for user actions Your code includes error handling - using specific functions for this purpose which is a nice way to encapsulate this functionality
API error handling Yes
Client-side validation Yes
Overall You were able to get the core of the functionality covered on this assignment. There is still some confusion about what goes where, but hopefully with the introduction of views, this will help make it even more clear. While it is totally reasonable that you do a lot of debugging throughout your application, the quantity of console.log statements throughout make it extremely difficult to follow along. Please review these statements (and commented out code) prior to submitting assignments in the future to make the final version of your code the most clean & clear.

const modal = $('#add-a-trip-form-container');
const openModal = $('#add-new-trip');
// const closeModal = $('.close');
const closeModal = document.getElementsByClassName("close")[0];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With jQuery available, you generally should be using document. for selectors since the jQuery shorthand is much shorter.

};
$('#status-messages').show();
},
sortBooks(event) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm is this method name leftover from the in-class example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants