Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes - Sarah Read-Brown - BackTREK #46

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

SRBusiness
Copy link

BackTREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? Models function mostly like they do in Ruby, the help you keep track of your data, saving it and loading it to and from you backend. In backbone they can also be a part of a collections.
How did the presence of Models and Collections change the way you thought about your app? Sort of. I had to figure out which part would be models (trips and reservations) plus how and IF they would fit into a larger collection (trips collection). The way of thinking about it wasn't too different from thinking about how we used models/classes in rails.
How do Backbone Events compare to DOM events? They are really similar except that backbone events are triggered when the data for a model or collection changes while dom event triggered by a users action.
How did you approach filtering? What was your data flow for this feature? I did not complete this.
What do you think of Backbone in comparison to raw JavaScript & jQuery? It can be helpful in organizing a bigger project.
Do you have any recommendations on how we could improve this project for the next cohort? This seemed like a huge project right before interview week and when I didn't complete it last week I had very little motivation to complete it can felt like preparing for my interviews was a much greater priority. I would slim down the project a little and let us focus on interview week.

…ss message, edited model errors handling for server side responses
…of the reporting and statu stuff works for both trip and reservation
@CheezItMan
Copy link

BackTREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits, and good commit messages
Comprehension questions Check, we understand it was a tough week
Organization
Models and collections are defined in separate files Check
Code that relies on the DOM is located in or called by $(document).ready Check
Code follows the Backbone data flow (DOM event -> update model or collection -> Backbone event -> update DOM) Check for listening for update events to trigger rendering. You would do something similar for the sort event.
Functionality
Display list of trips Check
Display trip details Check
Register for a trip Check, good validations!
Add a trip Check
Sort trips MISSING
General
Snappy visual feedback for user actions I like the modal for adding a trip, good UX overall
API error handling Check
Client-side validation Check, nicely done with Trip validation, they look good.
Overall Nice work, you hit most learning goals just missing sorting. I'd review that this week, just so you can make sure you understand the concept. It's a fairly common paradigm in programming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants