Stef & Laura -- Carets

[LauraAddams]

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	Based the instructions, they clearly implied a connection between the rentals for movies and customers, The conclusion was that, movies & customers has rentals and rentals belongs to movies and customers.
Describe a set of positive and negative test cases you implemented for a model.	There are tests for presence validations on movies. The movie must have a name to be valid so we tested with and without a title.
Describe a set of positive and negative test cases you implemented for a controller.	We tested cases for if there we no movies/customers and when there were movies/customers. Also tested the show page when it was a valid case and invalid.
How does your API respond when bad data is sent to it?	It returns Json reply of false and the appropriate 400 error.
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	We created a method of available inventory, for basic guidelines it just returns the inventory. We added in the model, and called to it in the serializer so it could be returned in the Json response.
Do you have any recommendations on how we could improve this project for the next cohort?	The current Postman information is not updated for the current, some of the naming is off which can be confusing to find the right settings.
Link to Trello	https://trello.com/b/XdYCTICm/api-video-store
Link to ERD	https://www.lucidchart.com/invitations/accept/aedcf96c-76b2-489d-9108-cfb588973e81

[tildeee]

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	x
Comprehension questions	x
General
Business Logic in Models	x
All 3 required endpoints return expected JSON data	x
Requests respond with appropriate HTTP Status Code	x
Errors are reported	x
Testing
Passes all Smoke Tests	x
Model Tests - all relations, validations, and custom functions test positive & negative cases	x
Controller Tests - URI parameters and data in the request body have positive & negative cases	x
Optionals
POST routes use URI parameter and request body to add a new record to the database
GET /customers shows how many movies are checked out by a customer
GET /movies/:title shows updated inventory
Overall

Overall: very clean code and thorough tests! Good job!