Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes - Kate Evans-Spitzer and Lauren Lee - Video Store Consumer #14

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

Guribot
Copy link

@Guribot Guribot commented Dec 21, 2017

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
For each person in your pair, describe something you learned from your partner during this project We both have different instincts towards design - I'm hesitant to create new models/views and tend towards putting logic in app.js, where Lauren has a better grasp on Backbone conventions/construction, so between the two of us we were able to both learn new ways of constructing our code.
What was one area of Backbone you gained more clarity on during this assignment? Working with Backbone's built-in API functionality, especially relating to post requests
Describe how you solved the problem of having lists of movies that look mostly the same but have different content Since our display lists the movies by their titles, and we refactored the API to only return data from the seeded database (not TMDb's database), we didn't have any problems with duplicate entries.
Describe how you handled rentals with Backbone? We did not do this optional step
Describe a DOM event your application handled Search - when the search form is submitted, a new MovieList collection is created using an optional "query" attribute that sends the search GET request to the API. The returned MovieList is rendered to the main list.
Describe a custom event your application handled We did not end up using any custom events on this project
Do you have any recommendations on how we could improve this project for the next cohort? We think, given the amount of time we had for the project, the requirements were fine. EDIT: after seeing the other teams' presentations, we realized that we totally misinterpreted some of the instructions - since we were the only team who did, it's probably safe to chalk this up to human error, but it may have helped us realize our misunderstanding to have had more specific language in the requirements section.

@droberts-sea
Copy link

Video Store Consumer

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene - pair contribution yes
Comprehension questions yes - Vocab nitpick: refactoring means restructuring code without changing behavior, usually to be more readable or extensible. If you add or remove features it's not refactoring, you're just making a change.
General
Search functionality some - not quite what we intended
Rental library listing functionality yes
Add to rental library functionality yes - not quite what we intended, but this is close enough
Underscore Templates yes
Overall Look & feel excellent work
Optionals
Overall You are correct that there was a requirements miss here. The two major learning goals for this project are owning both ends of an API, and working with multiple collections of the same type. You've clearly hit the first, but I don't think you had an opportunity to demonstrate the second.

That being said, working with complex data is something we've done in the past, and you'll be hard-pressed to avoid it in your capstones, so I'm not too worried. Just make sure to be intentional about it, and feel free to speak up if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants