Pipes - Amy Cash & Iuliia - WordGuess

[cashmonger]

Word Guess

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature	Feedback
How do you feel you and your partner did in sharing responsibilities?	Pretty Good
Describe an instance where you used a method for something to encapsulate the functionality within your class. What does it do? What are its inputs and outputs?	Show Letter. It checks whether the guessed letter is correct and updates the word blanks to add it in, if it is. Inputs: word and guess, returns blanks with correct letters added
Describe an instance where you used a local variable instead of an instance variable. Why did you make that choice?	We used a local variable for user input, because it needs to change every time the user enters something new.
What code, if any, did you feel like you were duplicating more than necessary?	There's nothing in particular.
Is there a specific piece of code you'd like feedback on?	The overall structure

[PilgrimMemoirs]

Word-Guess Game

What We're Looking For

Feature	Feedback
Baseline
Regular Commits with meaningful commit messages.	Needs improvement - should have more commits. First few commits should have been split into more than one. Good rule is a commit for each new function, or method.
Readable code with consistent indentation.	Well Done
Answered comprehension questions	Well Done
Product Functionalities
Created a Class to encapsulate game functionality.	Well Done
Used methods to DRY up your code.	Well Done
Created instance variables & local variables where appropriate.	Well Done
Used Arrays to store lists of letters guessed.	Mostly Good - see note below on Game Functionality
Used variables & random numbers to allow the game to function with multiple words, no hard-coded answers.	Well done
Programmed "defensively" to detect errors in user input.	Well Done
Overall	Submission almost meets project expectations, the submitted code has a significant bug in the game functionality that prevents a win from registering correctly. See note below on Game Functionality.
	Additional Feedback
methods	Nice use of methods to split up functionality with semantic naming. Nice work having methods return.
Game Functionality - can't win	I noticed that after I had the full word guessed correctly, I still was having to make guesses until I ran out of guess and was told I lost. Knowing that I had the word filled-in correctly I printed both @blank_word and @split word to terminal to compare and I got this (the first one @blank_word, the second @split_word): [" R ", " E ", " W ", " E ", " A ", " V ", " E ", " S "] ["R", "E", "W", "E", "A", "V", "E", "S"]. The letters in @blank_word have spaces in the string. Which is strange. Then I noticed line 136, where the string is being saved, @blank_word[index] = " #{element} ". Is the string interpolation needed? @blank_word[index] = element would work just fine, since element is already a string. After I changed that, everything worked peachy.