Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Averi and Guillermina -- Carets #18

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Averi and Guillermina -- Carets #18

wants to merge 24 commits into from

Conversation

murog
Copy link

@murog murog commented Aug 22, 2017

Word Guess

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How do you feel you and your partner did in sharing responsibilities? We switched between driver and navigator very seamlessly. We were able to communicate efficiently and respectfully.
Describe an instance where you used a method for something to encapsulate the functionality within your class. What does it do? What are its inputs and outputs? The didyouwin? method checks to see whether the word_display contains any underscores and returns either true or false. When the random_word is initialized, the word_display contains an underscore for every letter in the random word. As the user guesses correctly, each underscore is replaced with correctly guessed letters. Consequently, if the word_display does not contain any underscores, it indicates that the player wins.
Describe an instance where you used a local variable instead of an instance variable. Why did you make that choice? We created the letter_index method to compare user inputs against the letters in our random word as well as the entire word itself. If the input matches any of the random word's letters, the indices of those letters would be shoveled into the local variable of letter_indeces. We used the local variable to reduce the scope at which the letter index of a correct letter could be accessed.
What code, if any, did you feel like you were duplicating more than necessary? There are several instances in which we clear the screen and re-print the necessary information we want for the user. This could have been reduced into a method.
Is there a specific piece of code you'd like feedback on? It seemed most natural for us to design the game using a single class. We would like feedback on whether this would be more readable using more than one class.

@tildeee
Copy link

tildeee commented Aug 28, 2017

Word-Guess Game

What We're Looking For

Feature Feedback
Baseline
Regular Commits with meaningful commit messages. x
Readable code with consistent indentation. x
Answered comprehension questions x
Product Functionalities
Created a Class to encapsulate game functionality. Could be more separated
Used methods to DRY up your code. x
Created instance variables & local variables where appropriate. x
Used Arrays to store lists of letters guessed. x
Used variables & random numbers to allow the game to function with multiple words, no hard-coded answers. x
Programmed "defensively" to detect errors in user input. x

@tildeee
Copy link

tildeee commented Aug 28, 2017

Your project looks great!
You two decided to make one class called RandomWord. This class name isn't very specific or representative of the responsibilities you gave it. Maybe there's a way to make this more streamlined.

Overall good job

It's sooooooo fun by the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants