Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laura & Kayla -- Carets #20

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

LauraAddams
Copy link

Word Guess

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How do you feel you and your partner did in sharing responsibilities? We worked together really well! Responsibility wise, we were not as strong in the navigator and driver roles but discussed ideas and code together.
Describe an instance where you used a method for something to encapsulate the functionality within your class. What does it do? What are its inputs and outputs? We used methods for the full game and for the ascii arts. For the main ascii art, the input is the number of tries and the output is the art based off of that number.
Describe an instance where you used a local variable instead of an instance variable. Why did you make that choice? There are local variables for the game method, like the arrays wrong_guess and right_guess to keep take of the letter guesses the user makes.
What code, if any, did you feel like you were duplicating more than necessary? There might be some duplicate code, but none we can see that is obvious.
Is there a specific piece of code you'd like feedback on? Right now the game is only as one method and can be split into many more, maybe some advice on what should be split up.

@CheezItMan
Copy link

Word-Guess Game

What We're Looking For

Feature Feedback
Baseline
Regular Commits with meaningful commit messages. Reaonable number of commits for this project. I like how you put in who did the commit, nice.
Readable code with consistent indentation. Very clean code, very readable.
Answered comprehension questions Check, glad you worked well together.
Product Functionalities
Created a Class to encapsulate game functionality. Yes, but structurally this is very similar to if you'd created with just a series of methods and no class. It would be better to break down components of the game into individual objects and classes.
Used methods to DRY up your code. Well done.
Created instance variables & local variables where appropriate. Check
Used Arrays to store lists of letters guessed. Well done using arrays to store the letters guessed.
Used variables & random numbers to allow the game to function with multiple words, no hard-coded answers. Check, small list of possible words, but it works.
Programmed "defensively" to detect errors in user input. I would suggest not letting the user enter a letter that's not a letter (like '.' or ',' or '$' etc. I would also suggest that you don't count repeated guesses of the same letter. Using a loop to trap the user until they enter a valid value would be better.
Summary Nicely done, simple, but it works. I would suggest breaking different stages down into separate methods, notice your game method is really long. It could be broken up. I would also suggest using at least another class to encapsulate the concept of a word. That would track correct and incorrect guesses. Then the game could use that object. Overall however this was nicely done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants