Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carets- Julia and Maria's Word Guess Game #22

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

julmeier
Copy link

Word Guess

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How do you feel you and your partner did in sharing responsibilities? We shared the responsibilities equally.
Describe an instance where you used a method for something to encapsulate the functionality within your class. What does it do? What are its inputs and outputs? We created a method called "choose_path" - the input was the user's letter guess, and the output was calling the appropriate method.
Describe an instance where you used a local variable instead of an instance variable. Why did you make that choice? We used a local variable for "current_word" because we didn't want the variable to be changed unless called in the appropriate method.
What code, if any, did you feel like you were duplicating more than necessary? We think we didn't have a lot of duplication, but would love feedback if you can point out anywhere we can be less repetitive.
Is there a specific piece of code you'd like feedback on? Yes- classes. We struggled to understand how or why to divide this class into multiple classes.

@CheezItMan
Copy link

Word-Guess Game

What We're Looking For

Feature Feedback
Baseline
Regular Commits with meaningful commit messages. Very good number of commits.
Readable code with consistent indentation. Good consistent indentation, and I like how you organized your Game class. The methods also have readable names, although choose_path threw me a little bit.
Answered comprehension questions Check, learning how to break thing up into classes is a learned skill. I would have created a Word class which tracks the word and all guesses, then a Game class to run the game logic using the Word class as a component.
Product Functionalities
Created a Class to encapsulate game functionality. Check
Used methods to DRY up your code. Fairly DRY, I would suggest creating a method to print out the word with dashes for unguessed letters, as you seem to have one piece of repetition there. Otherwise pretty good.
Created instance variables & local variables where appropriate. Well done.
Used Arrays to store lists of letters guessed. check
Used variables & random numbers to allow the game to function with multiple words, no hard-coded answers. Instead used Faker which works very very well.
Programmed "defensively" to detect errors in user input. It's a little convoluted, but you are checking to verify that the input was previously entered. Well done.
Summary Well done, good use of methods to DRY up code and using instance variables to track information. You hit all the requirements, nicely done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants