Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bear Bandit Word Guess #23

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Bear Bandit Word Guess #23

wants to merge 14 commits into from

Conversation

skwiens
Copy link

@skwiens skwiens commented Aug 22, 2017

Word Guess

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How do you feel you and your partner did in sharing responsibilities? Good. Mutual working together. We worked together face to face for most of the project and a small division of tasks at the very end.
Describe an instance where you used a method for something to encapsulate the functionality within your class. What does it do? What are its inputs and outputs? print_guesses_art: the input was guesses_remaining and the output was the ascii art. It takes in where the player is in the game (guesses_remaining) and prints out a bear approaching (or eating) the picnic.
Describe an instance where you used a local variable instead of an instance variable. Why did you make that choice? level_choice. We used level_choice as a local variable to determine what level the player wanted to use, but ultimately it led to a case statement that determined the number of guesses the player had.
What code, if any, did you feel like you were duplicating more than necessary? Maybe we could have used less in initialize and reduce our use of instance variables.
Is there a specific piece of code you'd like feedback on? If we could better use what methods are where in the classes as well as separation of concerns.

t.add_row ["Guessed Words", game1.words_guessed.join(", ").to_s]
t << :separator
t.add_row ["Remaining Guesses", game1.guesses_remaining]
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table is so cool!

@tildeee
Copy link

tildeee commented Aug 28, 2017

Word-Guess Game

What We're Looking For

Feature Feedback
Baseline
Regular Commits with meaningful commit messages. x
Readable code with consistent indentation. x
Answered comprehension questions x
Product Functionalities
Created a Class to encapsulate game functionality. x
Used methods to DRY up your code. x
Created instance variables & local variables where appropriate. x
Used Arrays to store lists of letters guessed. x
Used variables & random numbers to allow the game to function with multiple words, no hard-coded answers. x
Programmed "defensively" to detect errors in user input. x

@tildeee
Copy link

tildeee commented Aug 28, 2017

Great code. You two used a variety of techniques with clear understanding of the material, and with great execution.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants