Carets- Julia Meier- Media-ranker-oath #39
Conversation
…el. In work#create method, set the current logged in user_id to the works' user_id
…rk and users not being able to vote on their own works. completed model testing
… have users assigned due to seed data
|
I had some issues with testing the error codes. For example, in the works_controller_test: |
|
Just a note, it seems that they've changed how things work so a redirect with a error code other than 3XX http://api.rubyonrails.org/classes/ActionController/Redirecting.html |
|
Hey Julia, Just some feedback on your Media-Ranker-OAuth. It's odd, but the PR seems different than your github repo, it looks like you did it via a branch. When I checked out that branch I was unable to run You also still have a large number of tests, both models & controllers broken. Something to work on. Overall it looks like you struggled a bit, but got most of the functionality, but little of the testing. |
| flash[:status] = :success | ||
| flash[:result_text] = "Successfully upvoted!" | ||
| status = :found | ||
| if @work.can_edit_or_delete_work?(session[:user_id]) |
There was a problem hiding this comment.
I was wrong earlier in that if you use redirect you can't return a status code other than 3XX, (redirection).
You can instead render something and give a response code, or just redirect with a flash notice.
| def edit | ||
| unless @work.can_edit_or_delete_work?(session[:user_id]) | ||
| redirect_to work_path(@work.id) |
There was a problem hiding this comment.
It would be good to add a filter or at least an if statement to make sure a user can't access this action unless they are the user who created the work.
| flash[:status] = :success | ||
| flash[:result_text] = "Successfully destroyed #{@media_category.singularize} #{@work.id}" | ||
| redirect_to root_path | ||
| if @work.can_edit_or_delete_work?(session[:user_id]) |
There was a problem hiding this comment.
This is just the sort of thing you'd want to put in the edit action.
| @@ -3,6 +3,6 @@ | |||
|
|
|||
There was a problem hiding this comment.
I would suggest something like this in your seeds file.
User.create!(username: "bob", email: "[email protected]", uid: 12345, provider: "google")
User.create!(username: "Ada", email: "[email protected]", uid: 12346, provider: "google")
CSV.foreach(media_file, headers: true, header_converters: :symbol, converters: :all) do |row|
data = Hash[row.headers.zip(row.fields)]
data[:user] = User.all.sample
# puts data
Work.create!(data)
end| @@ -27,7 +27,7 @@ | |||
| <%= link_to "Logged in as #{@login_user.username}", user_path(@login_user), class: "button" %> | |||
| <%= link_to "Log Out", logout_path, method: :post, class: "button" %> | |||
| <% else %> | |||
| <%= link_to "Log In", login_path, class: "button float-right" %> | |||
| <%= link_to "Log in with Github", "/auth/github", class: "button" %> | |||
There was a problem hiding this comment.
You should also add something for flash notices!
No description provided.