Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check that stack has been updated in CFNMain #156

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Add a check that stack has been updated in CFNMain #156

merged 1 commit into from
Dec 6, 2022

Conversation

adanaja
Copy link
Contributor

@adanaja adanaja commented Dec 6, 2022

Check for UPDATE_COMPLETE after execute_change_set and exit with error code 1 if the update failed

Ref #155

Check for UPDATE_COMPLETE after execute_change_set and exit with
error code 1 if the update failed

Ref #155
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #156 (8f3609e) into master (55987b4) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   78.33%   78.31%   -0.02%     
==========================================
  Files          43       43              
  Lines        3351     3353       +2     
==========================================
+ Hits         2625     2626       +1     
- Misses        726      727       +1     
Impacted Files Coverage Δ
src/e3/aws/cfn/main.py 75.29% <50.00%> (-0.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pierretr pierretr self-requested a review December 6, 2022 17:12
Copy link
Contributor

@pierretr pierretr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more pythonic way of returning an error would be to raise an exception here.
But that's not part of your change as the method was already returning 1 on failures.

@pierretr pierretr merged commit eebd559 into AdaCore:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants