Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Remove justifyContent: 'stretch' from ActionButton #61

Conversation

zachbharris
Copy link
Contributor

@zachbharris zachbharris commented Jul 6, 2021

Issue

justifyContent: 'stretch' is not supported in react-native and is giving a console error (no crashes). I believe these errors only show while in development as well, no production builds should show these errors.

Here are the available values for justifyContent in react-native: https://reactnative.dev/docs/flexbox#justify-content

Solution

  • remove justifyContent: 'stretch'

Additional Notes

Have been seeing this console error in non-adalo org apps while working on a feature.

@zachbharris zachbharris added the bug Something isn't working label Jul 6, 2021
@zachbharris zachbharris requested review from scott-massey and a team July 6, 2021 16:17
@zachbharris zachbharris self-assigned this Jul 6, 2021
Copy link
Contributor

@nucks nucks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't let me see the full file path from my phone, but aren't they used on web? And that's why the uf statements remove them from mobile devices?

@zachbharris
Copy link
Contributor Author

zachbharris commented Jul 7, 2021

It won't let me see the full file path from my phone, but aren't they used on web? And that's why the uf statements remove them from mobile devices?

The property is applied to web, but I don't see it giving any additional functionality. justifiedContent: 'stretch' isn't a supported react-native style according to their docs as well.

@nucks
Copy link
Contributor

nucks commented Jul 13, 2021

It won't let me see the full file path from my phone, but aren't they used on web? And that's why the uf statements remove them from mobile devices?

The property is applied to web, but I don't see it giving any additional functionality. justifiedContent: 'stretch' isn't a supported react-native style according to their docs as well.

I'd be really surprised if it's never been used at all. I'd almost rather keep it in the codebase than remove it without complete certainty that it's never been used and isn't being used.

@scott-massey
Copy link
Contributor

Jacob used it to fix an issue with the ActionButton, I forget what though. The code below was meant to remove the key/value pair on mobile though, so the solution should probably be just to fix that code instead.

@scott-massey
Copy link
Contributor

And sorry for the huge delay I just noticed this was waiting on me in the github integration on slack...

@scott-massey
Copy link
Contributor

should we try to merge this at some point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants