-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 Remove justifyContent: 'stretch'
from ActionButton
#61
🐞 Remove justifyContent: 'stretch'
from ActionButton
#61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't let me see the full file path from my phone, but aren't they used on web? And that's why the uf statements remove them from mobile devices?
The property is applied to |
I'd be really surprised if it's never been used at all. I'd almost rather keep it in the codebase than remove it without complete certainty that it's never been used and isn't being used. |
Jacob used it to fix an issue with the ActionButton, I forget what though. The code below was meant to remove the key/value pair on mobile though, so the solution should probably be just to fix that code instead. |
And sorry for the huge delay I just noticed this was waiting on me in the github integration on slack... |
should we try to merge this at some point? |
Issue
justifyContent: 'stretch'
is not supported inreact-native
and is giving a console error (no crashes). I believe these errors only show while in development as well, no production builds should show these errors.Here are the available values for
justifyContent
in react-native: https://reactnative.dev/docs/flexbox#justify-contentSolution
justifyContent: 'stretch'
Additional Notes
Have been seeing this console error in non-adalo org apps while working on a feature.