Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable resize so component isn't cut off #20

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

enable resize so component isn't cut off #20

wants to merge 4 commits into from

Conversation

quinnwai
Copy link
Contributor

Problem: Initial binding box was too small. Also, parts of the component were cut off if the timer/icons were sized too large

Solution: changed initial height/width and enabled resizing in the manifest

@quinnwai
Copy link
Contributor Author

P2 - Stopwatch component Issues in Native builds

scott-massey
scott-massey reviewed Jul 14, 2021
View reviewed changes
Copy link
Contributor

@scott-massey scott-massey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scott-massey scott-massey scott-massey approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quinnwai @scott-massey