feat: animate outgoing reactions #538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamant-al
requested changes
Oct 10, 2023
|
@adamant-al Please look again. |
adamant-al
reviewed
Oct 14, 2023
adamant-al
requested review from
bludnic,
martiliones,
just-software-dev and
RealGoodProgrammer
|
Any update here? |
bludnic
approved these changes
Nov 2, 2023
|
@adamant-al check now |
Merged
|
Looks complicated and still doesn't work with income reactions. Screenshot.2023-11-05.17.01.48.mov |
|
@adamant-al can't find an easy solution to animate incoming reactions. I created a separate task for that https://trello.com/c/zuIvK28d/458-animate-incoming-reaction |
|
You can postpone this task, but creating an additional task makes no sense. |
|
Closed in favor of #649 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an animation for the reaction. There is a question for clarification @adamant-al . Do you like this type of animation? There are others on this site, you can see https://animate.style/#documentation. At the moment, the animation is also triggered on page refresh. Is it ok to keep that behaviour?