Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate manual and lore from google doc #79 #92

Merged
merged 3 commits into from
Apr 8, 2018
Merged

Generate manual and lore from google doc #79 #92

merged 3 commits into from
Apr 8, 2018

Conversation

mathben
Copy link
Member

@mathben mathben commented Apr 8, 2018

From URL of google spreadsheet, can generate, with a specific header, the manual and lore content.
This feature is accessible from admin panel.

mathben added 3 commits April 1, 2018 18:30
@mathben
[AdminTL#83] Login: fix option hiden menu login when user is logging
c0a1a88
@mathben
[AdminTL#79] Doc Generator: support google drive spreadsheet to gener…
f23a56e 
…ate doc

- Implement config file to add the url of the spreadsheet to read
- Add google API key to connect to google API
- Add documentation for how to use it
- Generate Manual and Lore documentation from spreadsheet
- Add spreadsheet validation format
- Add editor admin page
- Add button to share document with writting permission to actual user
- Add verification when connect to remote document
- Persistente remote connection file
- Add generator button in editor page
- Validate email not exist before shared document permission
- Show status and error message for editor execution
- Reload and save manual documentation after generation
- Update url of doc from Client
- Inform user when missing permission for the software
- show email to invite when missing permission
@mathben
Base html: update fontawesome path from bower update
a5a2e2c
@mathben mathben added this to the First game scenario 2 milestone Apr 8, 2018
@mathben mathben requested a review from alexisbssn April 8, 2018 04:34
@mathben mathben mentioned this pull request Apr 8, 2018
Closed
alexisbssn
alexisbssn approved these changes Apr 8, 2018
View reviewed changes
Copy link
Contributor

@alexisbssn alexisbssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handlers.py -> le code de vérification des permissions admin est copié plusieurs fois. Possiblement l'extraire à sa propre fonction.

Je sais pas si c'est correct en python, mais en c# avoir plusieurs classes dans le même fichier c'est mal

@mathben
Copy link
Member Author

mathben commented Apr 8, 2018

  1. J'ai créé une tâche pour la gestion des permissions admin : Implement python decorator tornado with admin permission #94
    En effet, il faut faire du ménage à ce niveau. De plus, la nouvelle technique aura moins de risque d'erreur.
  2. En Python, un fichier est un module, contrairement en Java ou en C# que le fichier est une classe. Un module est comme un namespace, il contient plusieurs classes.
    Cependant, dans notre contexte, le fichier Handler commence à devenir chaotique et on va vite s'y perdre. Cette tâche va régler ce problème en séparant les fonctionnalités par module : Création de module dans la plateforme python #57

@mathben mathben merged commit 985e05b into AdminTL:develop Apr 8, 2018
@mathben mathben deleted the generate_manual_from_google_doc_#79 branch April 8, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexisbssn alexisbssn alexisbssn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
First game scenario 2
Development

Successfully merging this pull request may close these issues.
2 participants
@mathben @alexisbssn