Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13 ES5 syntax for utils #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

idir
Copy link

@idir idir commented Mar 3, 2021

Summary

Changes proposed in this pull request:

  • When we use ESM webpack importer instead of compiled lib in dist, we get issues on web browser that does not understand ES6 syntax such as IE11. Indeed, webpack+babel ignore node_modules and don't transpile these utils to ES5 before usage. Therefore it caused on our side issues for users who do checkout with fat arrow syntax. Furthermore, I have tested solutions such as upgrading to Babel 7 + babel.config.js instead of babelrc + are-you-es5 package. This latest does not consider index.js file used to generate the lib in the dist folder.
  • This pull request solve the issue by rewritting utils in ES5 syntax

Tested scenarios

  • Not applied. It does not impact utils usage.

Fixed issue: #13

@idir
Copy link
Author

idir commented Mar 11, 2021

Hello, @adyen-git-manager.

Can you check the PR above, please?

Thank you.

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant