3.5.0

3ds2/build.gradle

@@ -30,13 +30,6 @@ android {
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
 
     }
-
-    buildTypes {
-        release {
-            minifyEnabled false
-            proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
-        }
-    }
 }
 
 dependencies {

CHANGELOG.md

@@ -13,6 +13,16 @@
 [//]: <> (Add changes that not released yet into `Unreleased` section)
 [//]: <> (Comment `Unreleased` section if there are no changes)
 [//]: <> (## [Unreleased])
+## [3.5.0] - 2019-10-21
+### Added
+- WeChatPay SDK payment method.
+### Changed
+- Renamed `RecurringDetail` to `StoredPaymentMethod` to match the object array names on the [documentation](https://docs.adyen.com/api-explorer/#/PaymentSetupAndVerificationService/v50/paymentMethods__section_resParams).
+- Added the fields `holderName` and `shopperEmail` that were missing.
+- Precise CVC check in CardComponent for Amex card type.
+### Deprecated
+- Created new deprecated `RecurringDetail` to maintain backwards compatibility for now.
+
 ## [3.4.1] - 2019-10-07
 ### Added
 - MolpayComponents can how handle multiple MolPay PaymentMethods (molpay_ebanking_fpx_MY, molpay_ebanking_TH, molpay_ebanking_VN)

README.md

@@ -13,11 +13,11 @@ The Components are available through [jcenter][dl], you only need to add the Gra
 Import the Component module for the Payment Method you want to use by adding it to your `build.gradle` file.
 For example, for the Drop-in solution you should add:
 ```groovy
-implementation "com.adyen.checkout:drop-in:3.4.1"
+implementation "com.adyen.checkout:drop-in:3.5.0"
 ```
 For a Credit Card component you should add:
 ```groovy
-implementation "com.adyen.checkout:card-ui:3.4.1"
+implementation "com.adyen.checkout:card-ui:3.5.0"
 ```
 
 ## Drop-in
@@ -65,15 +65,16 @@ Don't forget to also add the service your manifest.
 Some payment methods need additional configuration. For example, to enable the card form, the Drop-in needs a public key from the Customer Area to be used for encryption. These payment method specific configuration parameters can be set in the `DropInConfiguration`:
 
 ```kotlin
-val dropInConfiguration = DropInConfiguration.Builder(this@MainActivity, YourDropInService::class.java)
+val dropInConfiguration = DropInConfiguration.Builder(this@MainActivity,
+resultIntent, YourDropInService::class.java)
     .addCardConfiguration(cardConfiguration)
     .build()
 ```
 
 After serializing the payment methods and creating the configuration, the Drop-in is ready to be initialized. Just call the `.startPayment()` method, the final result sent on the `CallResult` will be added to your `resultIntent` to start your Activity.
 
 ```kotlin
-DropIn.INSTANCE.startPayment(this@YourActivity, mPaymentMethodsApiResponse, dropInConfiguration, resultIntent)
+DropIn.startPayment(this@YourActivity, paymentMethodsApiResponse, dropInConfiguration)
 ```
 
 ## Components

README_TEMPLATE.md

@@ -65,15 +65,16 @@ Don't forget to also add the service your manifest.
 Some payment methods need additional configuration. For example, to enable the card form, the Drop-in needs a public key from the Customer Area to be used for encryption. These payment method specific configuration parameters can be set in the `DropInConfiguration`:
 
 ```kotlin
-val dropInConfiguration = DropInConfiguration.Builder(this@MainActivity, YourDropInService::class.java)
+val dropInConfiguration = DropInConfiguration.Builder(this@MainActivity,
+resultIntent, YourDropInService::class.java)
     .addCardConfiguration(cardConfiguration)
     .build()
 ```
 
 After serializing the payment methods and creating the configuration, the Drop-in is ready to be initialized. Just call the `.startPayment()` method, the final result sent on the `CallResult` will be added to your `resultIntent` to start your Activity.
 
 ```kotlin
-DropIn.INSTANCE.startPayment(this@YourActivity, mPaymentMethodsApiResponse, dropInConfiguration, resultIntent)
+DropIn.startPayment(this@YourActivity, paymentMethodsApiResponse, dropInConfiguration)
 ```
 
 ## Components

RELEASE_NOTES

@@ -1,5 +1,4 @@
 <ul>
-<li>UI Updates</li>
-<li>Update Molpay component to support Thailand and Vietnam</li>
+<li>Added WeChatPay component</li>
 <li>Bug Fixes</li>
 </ul>

base-ui/build.gradle

@@ -24,13 +24,6 @@ android {
 
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }
-
-    buildTypes {
-        release {
-            minifyEnabled false
-            proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
-        }
-    }
 }
 
 dependencies {

base-ui/src/main/java/com/adyen/checkout/base/ui/view/AdyenLinearLayout.java

@@ -48,7 +48,10 @@ public void attach(@NonNull ComponentT component, @NonNull LifecycleOwner lifecy
     }
 
     @NonNull
-    public ComponentT getComponent() {
+    protected ComponentT getComponent() {
+        if (mComponent == null) {
+            throw new RuntimeException("Should not get Component before it's attached");
+        }
         return mComponent;
     }
 }

base-v3/build.gradle

@@ -25,13 +25,6 @@ android {
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
 
     }
-
-    buildTypes {
-        release {
-            minifyEnabled false
-            proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
-        }
-    }
 }
 
 dependencies {

base-v3/src/main/java/com/adyen/checkout/base/api/LogoConnectionTask.java

@@ -56,7 +56,7 @@ protected void done() {
                 final BitmapDrawable result = get(SAFETY_TIMEOUT, TimeUnit.MILLISECONDS);
                 notifyLogo(result);
             } catch (ExecutionException e) {
-                Logger.e(TAG, "Execution failed.", e);
+                Logger.e(TAG, "Execution failed for logo  - " + getLogoUrl());
                 notifyFailed();
             } catch (InterruptedException e) {
                 Logger.e(TAG, "Execution interrupted.", e);

base-v3/src/main/java/com/adyen/checkout/base/component/BasePaymentComponent.java

@@ -40,7 +40,7 @@ public abstract class BasePaymentComponent<ConfigurationT extends Configuration,
 
     private final MutableLiveData<ComponentError> mComponentErrorLiveData = new MutableLiveData<>();
 
-    @NonNull
+    @Nullable
     private OutputDataT mOutputData;
 
     private final MutableLiveData<OutputDataT> mOutputLiveData = new MutableLiveData<>();
@@ -57,8 +57,6 @@ public abstract class BasePaymentComponent<ConfigurationT extends Configuration,
     public BasePaymentComponent(@NonNull PaymentMethod paymentMethod, @NonNull ConfigurationT configuration) {
         super(paymentMethod, configuration);
         assertSupported(paymentMethod);
-        mOutputData = createEmptyOutputData();
-        mOutputLiveData.setValue(mOutputData);
     }
 
     @SuppressWarnings("MissingDeprecated")
@@ -96,7 +94,7 @@ public PaymentComponentState getState() {
      */
     public final void inputDataChanged(@NonNull InputDataT inputData) {
         final OutputDataT newOutputData = onInputDataChanged(inputData);
-        if (!mOutputData.equals(newOutputData)) {
+        if (!newOutputData.equals(mOutputData)) {
             mOutputData = newOutputData;
             mOutputLiveData.setValue(mOutputData);
             notifyStateChanged();
@@ -137,7 +135,7 @@ public void sendAnalyticsEvent(@NonNull Context context) {
         }
     }
 
-    @NonNull
+    @Nullable
     protected OutputDataT getOutputData() {
         return mOutputData;
     }
@@ -151,9 +149,6 @@ protected OutputDataT getOutputData() {
     @NonNull
     protected abstract OutputDataT onInputDataChanged(@NonNull InputDataT inputData);
 
-    @NonNull
-    protected abstract OutputDataT createEmptyOutputData();
-
     @NonNull
     @WorkerThread
     protected abstract PaymentComponentState createComponentState();

base-v3/src/main/java/com/adyen/checkout/base/component/EmptyInputData.java

@@ -0,0 +1,12 @@
+/*
+ * Copyright (c) 2019 Adyen N.V.
+ *
+ * This file is open source and available under the MIT license. See the LICENSE file for more info.
+ *
+ * Created by caiof on 15/10/2019.
+ */
+
+package com.adyen.checkout.base.component;
+
+public final class EmptyInputData implements InputData {
+}

base-v3/src/main/java/com/adyen/checkout/base/component/EmptyOutputData.java

@@ -0,0 +1,16 @@
+/*
+ * Copyright (c) 2019 Adyen N.V.
+ *
+ * This file is open source and available under the MIT license. See the LICENSE file for more info.
+ *
+ * Created by caiof on 15/10/2019.
+ */
+
+package com.adyen.checkout.base.component;
+
+public final class EmptyOutputData implements OutputData {
+    @Override
+    public boolean isValid() {
+        return true;
+    }
+}

base-v3/src/main/java/com/adyen/checkout/base/model/PaymentMethodsApiResponse.java

@@ -14,7 +14,7 @@
 
 import com.adyen.checkout.base.model.paymentmethods.PaymentMethod;
 import com.adyen.checkout.base.model.paymentmethods.PaymentMethodsGroup;
-import com.adyen.checkout.base.model.paymentmethods.RecurringDetail;
+import com.adyen.checkout.base.model.paymentmethods.StoredPaymentMethod;
 import com.adyen.checkout.core.exception.ModelSerializationException;
 import com.adyen.checkout.core.model.JsonUtils;
 import com.adyen.checkout.core.model.ModelObject;
@@ -46,7 +46,7 @@ public JSONObject serialize(@NonNull PaymentMethodsApiResponse modelObject) {
             try {
                 jsonObject.putOpt(GROUPS, ModelUtils.serializeOptList(modelObject.getGroups(), PaymentMethodsGroup.SERIALIZER));
                 jsonObject.putOpt(STORED_PAYMENT_METHODS,
-                        ModelUtils.serializeOptList(modelObject.getStoredPaymentMethods(), RecurringDetail.SERIALIZER));
+                        ModelUtils.serializeOptList(modelObject.getStoredPaymentMethods(), StoredPaymentMethod.SERIALIZER));
                 jsonObject.putOpt(PAYMENT_METHODS, ModelUtils.serializeOptList(modelObject.getPaymentMethods(), PaymentMethod.SERIALIZER));
             } catch (JSONException e) {
                 throw new ModelSerializationException(PaymentMethodsApiResponse.class, e);
@@ -60,15 +60,15 @@ public PaymentMethodsApiResponse deserialize(@NonNull JSONObject jsonObject) {
             final PaymentMethodsApiResponse paymentMethodsApiResponse = new PaymentMethodsApiResponse();
             paymentMethodsApiResponse.setGroups(ModelUtils.deserializeOptList(jsonObject.optJSONArray(GROUPS), PaymentMethodsGroup.SERIALIZER));
             paymentMethodsApiResponse.setStoredPaymentMethods(
-                    ModelUtils.deserializeOptList(jsonObject.optJSONArray(STORED_PAYMENT_METHODS), RecurringDetail.SERIALIZER));
+                    ModelUtils.deserializeOptList(jsonObject.optJSONArray(STORED_PAYMENT_METHODS), StoredPaymentMethod.SERIALIZER));
             paymentMethodsApiResponse.setPaymentMethods(
                     ModelUtils.deserializeOptList(jsonObject.optJSONArray(PAYMENT_METHODS), PaymentMethod.SERIALIZER));
             return paymentMethodsApiResponse;
         }
     };
 
     private List<PaymentMethodsGroup> groups;
-    private List<RecurringDetail> storedPaymentMethods;
+    private List<StoredPaymentMethod> storedPaymentMethods;
     private List<PaymentMethod> paymentMethods;
 
     @Override
@@ -82,7 +82,7 @@ public List<PaymentMethodsGroup> getGroups() {
     }
 
     @Nullable
-    public List<RecurringDetail> getStoredPaymentMethods() {
+    public List<StoredPaymentMethod> getStoredPaymentMethods() {
         return storedPaymentMethods;
     }
 
@@ -95,7 +95,7 @@ public void setGroups(@Nullable List<PaymentMethodsGroup> groups) {
         this.groups = groups;
     }
 
-    public void setStoredPaymentMethods(@Nullable List<RecurringDetail> storedPaymentMethods) {
+    public void setStoredPaymentMethods(@Nullable List<StoredPaymentMethod> storedPaymentMethods) {
         this.storedPaymentMethods = storedPaymentMethods;
     }