Update nodejs version to 18

ISSUE: ADPM-34
Adyen · Oct 10, 2023 · b1a3e4f · b1a3e4f
1 parent 3581bed
commit b1a3e4f
Show file tree

Hide file tree

Showing 10 changed files with 18 additions and 20 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -19,10 +19,10 @@ jobs:
         working-directory: notification
     steps:
       - uses: actions/checkout@v4
-      - name: Use Node.js 16.x
+      - name: Use Node.js 18.x
         uses: actions/setup-node@v3
         with:
-          node-version: '16.x'
+          node-version: '18.x'
       - run: npm ci
       - run: npx lockfile-lint --path package-lock.json --allowed-schemes "https:" "git+https:" --allowed-hosts npm github.com
       - run: npm run check
@@ -46,7 +46,7 @@ jobs:
             --region europe-west3 \
             --source sources \
             --entry-point notificationTrigger \
-            --runtime nodejs16 \
+            --runtime nodejs18 \
             --trigger-http \
             --allow-unauthenticated
   
@@ -65,10 +65,10 @@ jobs:
         working-directory: extension
     steps:
       - uses: actions/checkout@v4
-      - name: Use Node.js 16.x
+      - name: Use Node.js 18.x
         uses: actions/setup-node@v3
         with:
-          node-version: '16.x'
+          node-version: '18.x'
       - run: npm ci
       - run: npx lockfile-lint --path package-lock.json --allowed-schemes "https:" "git+https:" --allowed-hosts npm github.com
       - run: npm run check
@@ -91,7 +91,7 @@ jobs:
             --region europe-west3 \
             --source sources \
             --entry-point extensionTrigger \
-            --runtime nodejs16 \
+            --runtime nodejs18 \
             --trigger-http \
             --allow-unauthenticated
       - run: npm run test-ci
@@ -109,10 +109,10 @@ jobs:
         working-directory: notification
     steps:
       - uses: actions/checkout@v4
-      - name: Use Node.js 16.x
+      - name: Use Node.js 18.x
         uses: actions/setup-node@v3
         with:
-          node-version: '16.x'
+          node-version: '18.x'
       - run: npm ci
       - run: npx lockfile-lint --path package-lock.json --allowed-schemes "https:" "git+https:" --allowed-hosts npm github.com
-      - run: npm run test-ci
+      - run: npm run test-ci
diff --git a/deployment-examples/gcp/serverless/extension/README.md b/deployment-examples/gcp/serverless/extension/README.md
@@ -4,7 +4,7 @@
 2. Extension module requires `ADYEN_INTEGRATION_CONFIG` as `Runtime environment variable` or `.extensionrc` file to configure with [external file configuration](../../../../extension/docs/HowToRun.md#external-file-configuration).
 3. Deployments work by uploading an archive containing your function's source code to a Google Cloud Storage bucket.
 To bundle the extension module, navigate to in `extension` folder run `npm run zip-google-function`. 
-4. Specify the `extensionTrigger` as the entry point function in your GCP Cloud Function configuration and runtime as `Node.js 16`. 
+4. Specify the `extensionTrigger` as the entry point function in your GCP Cloud Function configuration and runtime as `Node.js 18`. 
 5. Please check our [faq](../../../../docs/FAQ.md) for your deployment.
 
 ### Helpful Links: 

diff --git a/deployment-examples/gcp/serverless/notification/README.md b/deployment-examples/gcp/serverless/notification/README.md
@@ -4,7 +4,7 @@
 2. Notification module requires `ADYEN_INTEGRATION_CONFIG` as `Runtime environment variable` or `.notificationrc` file to configure with [external file configuration](../../../../notification/docs/HowToRun.md#external-file-configuration).
 3. Deployments work by uploading an archive containing your function's source code to a Google Cloud Storage bucket.
 To bundle the extension module, navigate to in `notification` folder run `npm run zip-google-function`. 
-4. Specify the `notificationTrigger` as the entry point function in your GCP Cloud Function configuration and runtime as `Node.js 16`.
+4. Specify the `notificationTrigger` as the entry point function in your GCP Cloud Function configuration and runtime as `Node.js 18`.
 5. Please check our general [faq](../../../../docs/FAQ.md) for your deployment.
 
 ### Helpful Links: 

diff --git a/docs/ContributionGuide.md b/docs/ContributionGuide.md
@@ -12,7 +12,7 @@
 ## Prerequisites
 
 Minimum requirements are:
- - **Node.js** version 16.
+ - **Node.js** version 18.
  - **Npm** version 6.
 
 You can install all dependencies using `npm` with following command:

diff --git a/extension/Dockerfile b/extension/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:16-alpine3.14
+FROM node:18-alpine3.18
 MAINTAINER Professional Services <[email protected]>
 
 WORKDIR /app

diff --git a/extension/package-lock.json b/extension/package-lock.json
diff --git a/extension/package.json b/extension/package.json
@@ -38,7 +38,7 @@
     "email": "[email protected]"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "contributors": [],
   "bugs": {

diff --git a/notification/Dockerfile b/notification/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:16-alpine3.14
+FROM node:18-alpine3.18
 MAINTAINER Professional Services <[email protected]>
 
 WORKDIR /app

diff --git a/notification/package-lock.json b/notification/package-lock.json
diff --git a/notification/package.json b/notification/package.json
@@ -37,8 +37,7 @@
     "email": "[email protected]"
   },
   "engines": {
-    "node": ">=16",
-    "npm": ">=6"
+    "node": ">=18"
   },
   "contributors": [],
   "bugs": {